From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0BFC47094 for ; Tue, 8 Jun 2021 00:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67E6A61208 for ; Tue, 8 Jun 2021 00:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhFHArt (ORCPT ); Mon, 7 Jun 2021 20:47:49 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:45603 "EHLO mail-pl1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbhFHArs (ORCPT ); Mon, 7 Jun 2021 20:47:48 -0400 Received: by mail-pl1-f177.google.com with SMTP id 11so9668393plk.12 for ; Mon, 07 Jun 2021 17:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TkL1IBMNyy9LCho9RG5yvgyLt1iIVTJx8MHgf8Y6U3Q=; b=NnvpGsbQtNYBBeTeM6yzv5NrHus0ByzFMz20705XPCu1/dSzypTKxHlFJW43TR2PR3 0obMNKXskwYtyXSeiadXUVm3o5qobDG6N6AtuqD2394l492Fq3cR2nzKvvuz+ewY0suQ z7bWYCd3lC1ughiUCrM+LIy7CroaG02VEwtwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TkL1IBMNyy9LCho9RG5yvgyLt1iIVTJx8MHgf8Y6U3Q=; b=qFf8v9DSa8GM1yj4AFmTMCSgLAyGdIae16HXHtb0zHOSWAG4Zphkz5ovGKHKprcxr0 ckOCL+IkO31Bj+VYYdfZXLsiXkiuEpcCyxfepzAtOwm0BiO4jjo+odelml3EjbNoh1vn 4wHMrFG76Bjz6A9Qc4ntO8gJMI1MhNj6hszYRJCUJh+rww9xC+6K1TM6UsqGC4YFHpRg qVCEeahfRR0yzeW9KBu3Wmhx3XqCSqa4sZgPpBMDt8sPU2HlTNVkDmLhI2FHsmEJj7aV fXXuCfxMUhbi2crz/vcPPCNXV5ofw1mljR7pSH94dJ3niS7mpvAtcuUzBNHMicpovZsF 9XYg== X-Gm-Message-State: AOAM530moLbBNEIu7B/mX7wBDW+sekpza8cj+SdslN0aAcqDGib1Fm68 Iz8sVLSDWv1hCNNaBSIKV7eGAg== X-Google-Smtp-Source: ABdhPJyApYLIqMYQ7LGTK2gmVHqQ5rm0+vYcRttlyB+830rpLYbWYZEJuWO+4t5lsTF787gTN6Uhng== X-Received: by 2002:a17:90a:4dc1:: with SMTP id r1mr23121759pjl.192.1623113096781; Mon, 07 Jun 2021 17:44:56 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:1193:5ba8:74e4:8b6e]) by smtp.gmail.com with ESMTPSA id r9sm9311391pfq.158.2021.06.07.17.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 17:44:56 -0700 (PDT) Date: Tue, 8 Jun 2021 09:44:51 +0900 From: Sergey Senozhatsky To: Maxim Levitsky Cc: Sergey Senozhatsky , Paolo Bonzini , Marc Zyngier , Vitaly Kuznetsov , Peter Zijlstra , Suleiman Souhlal , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/2] kvm: x86: implement KVM PM-notifier Message-ID: References: <20210606021045.14159-1-senozhatsky@chromium.org> <20210606021045.14159-2-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On (21/06/07 15:54), Maxim Levitsky wrote: > > Overall this looks OK to me. > > Do you have a test case in which this patch helps to make the guest behave better after > the host suspend though? I tested this and I don't see any significant change. > (guest works after host suspend before and after, and I still have clocksource > watchdogs firing in the guest) Yes, we have automated suspend-resume tests. What happens for us is that, when not properly paused, guests, upon host resume, discover jiffies spikes and trigger all sort of watchdogs.