Re: [PATCH] serial: sh-sci: Remove unused STEPFN() macro

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Mon, Jun 07, 2021 at 06:51:54PM +0200, Niklas Söderlund wrote:
> On 2021-06-07 16:43:45 +0200, Geert Uytterhoeven wrote:
> > The last user of the STEPFN() macro was removed in commit
> > d5cb1319a91d4f13 ("serial: sh-sci: Remove manual break debouncing").
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

A simple and good fix.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > ---
> >  drivers/tty/serial/sh-sci.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index 4baf1316ea729931..946c4bd920f48960 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -840,9 +840,6 @@ static void sci_transmit_chars(struct uart_port *port)
> >  
> >  }
> >  
> > -/* On SH3, SCIF may read end-of-break as a space->mark char */
> > -#define STEPFN(c)  ({int __c = (c); (((__c-1)|(__c)) == -1); })
> > -
> >  static void sci_receive_chars(struct uart_port *port)
> >  {
> >  	struct tty_port *tport = &port->state->port;

-- 
Regards,

Laurent Pinchart