From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D3BC4707F for ; Fri, 28 May 2021 03:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A58A3613D4 for ; Fri, 28 May 2021 03:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236335AbhE1DqJ (ORCPT ); Thu, 27 May 2021 23:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234255AbhE1DqI (ORCPT ); Thu, 27 May 2021 23:46:08 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06D85C061760 for ; Thu, 27 May 2021 20:44:35 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id s19so2973425oic.7 for ; Thu, 27 May 2021 20:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VWWrXtqxypaG6W94Jcb7Nqjb7DgWl7Dvm/E9oGzGZbY=; b=gGsvGbKh9TFq4frPlNvRb4UTOPbO3ODdYCRS/termttaL9wBaX/aVYbXiCVDAI8hMc 3hw0s9WwmHoxF5hjnKKreRK1hjcX9JzboDsyo7opzQPjDFWZVP8iw+2c0sqs/ON4FFwq ImwSfnInJr0JrFAx0pjBIbHg6GInSbC1WafQCc839WqhLqCgjavP+XkM9C1sC6MGLX1e M0WOF9n4SVU8oysKjHTA2DG9+Jd724cUJmCY9msOZq3HfTYBLOtSukYgWZBPsXUNgyU7 nYcg/hPNrJG/MQtTWJZgZM1e69rf1/cdg8h4oi/Rj5NbZbIInlSHb66TEJ/EXVISbVVN pfZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VWWrXtqxypaG6W94Jcb7Nqjb7DgWl7Dvm/E9oGzGZbY=; b=jxhyq5BnH4w3ODa0ZrIz28oe79wv8mfifux+IStNwk3mtlM5Si0AMPdoJWwYevtfiW Xj+0FgWNqp4Om6QmCk2qgpv/6XH/Rox3cXpMBGT0TDIpSSfcNJ5S2BCyJn1gYLgWqdl/ prB8g81IBgWNzi4G40Rz50J0bLJImWNR2KV0o/BrZevEdAk7hhHC/wXQ9MF98/ZRwTZR mrKyhkiyZQvGWoxMQxuDjOtwFRe9WVP0+nCMK9ZYd0eep0Y2/oNduatdp9muxYBvZlwn R/n64glBKEPMZiVKCTutjlIKk3MD/SUoVT9UdmcVaRxy9en56oIVENcZ+AoEE9aDmnez yFDw== X-Gm-Message-State: AOAM533XKZNLLfv/roErDMEhdjXijw/2Lo2qR47KZroIKRqEkjhQdH9k c47GzkanLpNh7xxBJFREGkF4ow== X-Google-Smtp-Source: ABdhPJzIHO4BdhieqQHBdFlwXeo4p1xzGRxy0ToJKelI3up3VqCBFqUI2lIb1e3HK958Nnpfw7QwNw== X-Received: by 2002:a05:6808:1149:: with SMTP id u9mr4467883oiu.61.1622173474368; Thu, 27 May 2021 20:44:34 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id p22sm846364oop.7.2021.05.27.20.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 20:44:33 -0700 (PDT) Date: Thu, 27 May 2021 22:44:32 -0500 From: Bjorn Andersson To: Siddharth Gupta Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH 2/3] remoteproc: core: Move validate before device add Message-ID: References: <1621284349-22752-1-git-send-email-sidgup@codeaurora.org> <1621284349-22752-3-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621284349-22752-3-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 17 May 15:45 CDT 2021, Siddharth Gupta wrote: > We can validate whether the remoteproc is correctly setup before > calling making the cdev_add and device_add calls. This saves us > the trouble of cleaning up later on. > Reviewed-by: Bjorn Andersson > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 562355a..45d09bf 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -2316,16 +2316,16 @@ int rproc_add(struct rproc *rproc) > struct device *dev = &rproc->dev; > int ret; > > - /* add char device for this remoteproc */ > - ret = rproc_char_device_add(rproc); > + ret = rproc_validate(rproc); > if (ret < 0) > return ret; > > - ret = device_add(dev); > + /* add char device for this remoteproc */ > + ret = rproc_char_device_add(rproc); > if (ret < 0) > return ret; > > - ret = rproc_validate(rproc); > + ret = device_add(dev); > if (ret < 0) > return ret; > > -- > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBA0C47089 for ; Fri, 28 May 2021 03:45:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6BA613AB for ; Fri, 28 May 2021 03:45:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A6BA613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SDze8jcUIUMlEt8Y8Pa8wGQG5M+gSKACirrWzskiHAE=; b=1nUgxUYB9w7jJe /pKJh3JCucjPSN78ZoFJtG//G+znmjJQxzTf7e5PABh4/2kQCvVFXinrQwZYSO6pEXhJkp7poE9KA axbbLw8pLjLbkak2OpI7BA0MFaf1UrsPM48glMQxZO3iiceCq8vVgHQS9DlEkZIEo81+z4xMT7qsn /ySkYiE9Ut7TY1zM6Rh1mLFBu1ZIHiSnML8bg8joY9Wm6iXZWN4v2+y4WMXRjJnu+wmEovgkpgrzJ fUAVzVY8yIJ2RoCDOKIRtkFT3OjB+aRgJF9yJrm3nUo9bZ84/hygIphJ3QOyL7U5hRP8tkgccTaQJ gFQ3siFl0cnf6U+0vIFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmTQM-00BfKA-1P; Fri, 28 May 2021 03:44:38 +0000 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmTQI-00BfJ7-Us for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 03:44:36 +0000 Received: by mail-oi1-x231.google.com with SMTP id y76so2969592oia.6 for ; Thu, 27 May 2021 20:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VWWrXtqxypaG6W94Jcb7Nqjb7DgWl7Dvm/E9oGzGZbY=; b=gGsvGbKh9TFq4frPlNvRb4UTOPbO3ODdYCRS/termttaL9wBaX/aVYbXiCVDAI8hMc 3hw0s9WwmHoxF5hjnKKreRK1hjcX9JzboDsyo7opzQPjDFWZVP8iw+2c0sqs/ON4FFwq ImwSfnInJr0JrFAx0pjBIbHg6GInSbC1WafQCc839WqhLqCgjavP+XkM9C1sC6MGLX1e M0WOF9n4SVU8oysKjHTA2DG9+Jd724cUJmCY9msOZq3HfTYBLOtSukYgWZBPsXUNgyU7 nYcg/hPNrJG/MQtTWJZgZM1e69rf1/cdg8h4oi/Rj5NbZbIInlSHb66TEJ/EXVISbVVN pfZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VWWrXtqxypaG6W94Jcb7Nqjb7DgWl7Dvm/E9oGzGZbY=; b=liywZY0tFG0vsdDsCAcix4mF+gwDvVBjc3Y1B8OeqUI/4MFEcoOmTwtyBDGzTR8GNh uVtUbhFH4q+mrbUh6pmEjjIQnkUeVYQcj+2FC/8LF2hwWonsPtZdZixW3sTzKN2SudhS jktUsKEX6ss9Xq6uuWj1w7y5p7zGOLQc8OUjJCwn4/gCSurE5VBQs/mY2VjiB8KmmKVW KQCbVgzdSTN429zQAp06Fj915CL6d9OTuUmVbMRi330ZbMVcxeQl+MUxVTBvuXb7ubvy HEVCC10kMZxONjLNfiyuyJChO0fUkFJK17nyh2BnlU2/nnodf9xJw7Xt6Q7t4e9abflq tRcQ== X-Gm-Message-State: AOAM532DVYwEOH8c1ftLgmhWVgX0915nFBEfYZ8+yTH/xxoQDdBwM8VM cyMIL08imSMkzA54Qp8MuJc8dw== X-Google-Smtp-Source: ABdhPJzIHO4BdhieqQHBdFlwXeo4p1xzGRxy0ToJKelI3up3VqCBFqUI2lIb1e3HK958Nnpfw7QwNw== X-Received: by 2002:a05:6808:1149:: with SMTP id u9mr4467883oiu.61.1622173474368; Thu, 27 May 2021 20:44:34 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id p22sm846364oop.7.2021.05.27.20.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 20:44:33 -0700 (PDT) Date: Thu, 27 May 2021 22:44:32 -0500 From: Bjorn Andersson To: Siddharth Gupta Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH 2/3] remoteproc: core: Move validate before device add Message-ID: References: <1621284349-22752-1-git-send-email-sidgup@codeaurora.org> <1621284349-22752-3-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1621284349-22752-3-git-send-email-sidgup@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_204435_020743_BF8DE9A0 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 17 May 15:45 CDT 2021, Siddharth Gupta wrote: > We can validate whether the remoteproc is correctly setup before > calling making the cdev_add and device_add calls. This saves us > the trouble of cleaning up later on. > Reviewed-by: Bjorn Andersson > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 562355a..45d09bf 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -2316,16 +2316,16 @@ int rproc_add(struct rproc *rproc) > struct device *dev = &rproc->dev; > int ret; > > - /* add char device for this remoteproc */ > - ret = rproc_char_device_add(rproc); > + ret = rproc_validate(rproc); > if (ret < 0) > return ret; > > - ret = device_add(dev); > + /* add char device for this remoteproc */ > + ret = rproc_char_device_add(rproc); > if (ret < 0) > return ret; > > - ret = rproc_validate(rproc); > + ret = device_add(dev); > if (ret < 0) > return ret; > > -- > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel