From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Mon, 31 May 2021 14:35:24 +0200 Subject: [LTP] [PATCH 2/2] tst_test: using SIGTERM to terminate process In-Reply-To: References: <20210518122610.17171-1-liwang@redhat.com> <20210518122610.17171-2-liwang@redhat.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > But one more strange thing here. > I wonder why this even works. $pid is used in _tst_kill_test and defined > in _tst_setup_timer as a local variable. > It looks like it is inherited through the call chain and since it is > copied to the background process, it cannot be manipulated by the tests. > Still I would vote for changing this at some point, because it is highly > confusing. That's actually a correct and well defined behavior, if you call a function g from function f the function g has access to the variables local to f. And yes it's confusing, but the alternative is having another global variable which I do not think is much better than this. -- Cyril Hrubis chrubis@suse.cz