From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Sodhi, Vunny" <vunny.sodhi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Sodhi@freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Add support of MOD_Y_TILED during fb init
Date: Mon, 31 May 2021 17:05:37 +0300 [thread overview]
Message-ID: <YLTtMS4AOu2d7kmo@intel.com> (raw)
In-Reply-To: <1622460737-46494-1-git-send-email-vunny.sodhi@intel.com>
On Mon, May 31, 2021 at 07:32:17PM +0800, Sodhi, Vunny wrote:
> Adding Y_TILED modifier which is needed to support DRM_FORMAT_NV12
> during framebuffer initialization.
>
> Signed-off-by: Sodhi, Vunny <vunny.sodhi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index caf0414..a9b1b62 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -11610,8 +11610,10 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
> if (tiling == I915_TILING_X) {
> mode_cmd->modifier[0] = I915_FORMAT_MOD_X_TILED;
> } else if (tiling == I915_TILING_Y) {
> + mode_cmd->modifier[0] = I915_FORMAT_MOD_Y_TILED;
> + } else {
This is just the legacy bo tiling->modifier path, which is not needed by
any old userspace, and all modern userspace should just use modifiers.
> drm_dbg_kms(&dev_priv->drm,
> - "No Y tiling for legacy addfb\n");
> + "Unsupported tiling for legacy addfb\n");
> goto err;
> }
> }
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-05-31 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 11:32 [Intel-gfx] [PATCH] drm/i915/display: Add support of MOD_Y_TILED during fb init Sodhi, Vunny
2021-05-31 12:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-05-31 14:05 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLTtMS4AOu2d7kmo@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Sodhi@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vunny.sodhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.