From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: linus.walleij@linaro.org, vkoul@kernel.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: Fix duplication in gpio_groups
Date: Mon, 31 May 2021 11:00:23 -0500 [thread overview]
Message-ID: <YLUIF84u6VjHyNnp@builder.lan> (raw)
In-Reply-To: <20210526082857.174682-1-manivannan.sadhasivam@linaro.org>
On Wed 26 May 03:28 CDT 2021, Manivannan Sadhasivam wrote:
> "gpio52" and "gpio53" are duplicated in gpio_groups, fix them!
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Fixes: ac43c44a7a37 ("pinctrl: qcom: Add SDX55 pincontrol driver")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sdx55.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdx55.c b/drivers/pinctrl/qcom/pinctrl-sdx55.c
> index 5aaf57b40407..0bb4931cec59 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sdx55.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sdx55.c
> @@ -410,15 +410,15 @@ static const char * const gpio_groups[] = {
> "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> "gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48", "gpio49",
> - "gpio50", "gpio51", "gpio52", "gpio52", "gpio53", "gpio53", "gpio54",
> - "gpio55", "gpio56", "gpio57", "gpio58", "gpio59", "gpio60", "gpio61",
> - "gpio62", "gpio63", "gpio64", "gpio65", "gpio66", "gpio67", "gpio68",
> - "gpio69", "gpio70", "gpio71", "gpio72", "gpio73", "gpio74", "gpio75",
> - "gpio76", "gpio77", "gpio78", "gpio79", "gpio80", "gpio81", "gpio82",
> - "gpio83", "gpio84", "gpio85", "gpio86", "gpio87", "gpio88", "gpio89",
> - "gpio90", "gpio91", "gpio92", "gpio93", "gpio94", "gpio95", "gpio96",
> - "gpio97", "gpio98", "gpio99", "gpio100", "gpio101", "gpio102",
> - "gpio103", "gpio104", "gpio105", "gpio106", "gpio107",
> + "gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55", "gpio56",
> + "gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62", "gpio63",
> + "gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69", "gpio70",
> + "gpio71", "gpio72", "gpio73", "gpio74", "gpio75", "gpio76", "gpio77",
> + "gpio78", "gpio79", "gpio80", "gpio81", "gpio82", "gpio83", "gpio84",
> + "gpio85", "gpio86", "gpio87", "gpio88", "gpio89", "gpio90", "gpio91",
> + "gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97", "gpio98",
> + "gpio99", "gpio100", "gpio101", "gpio102", "gpio103", "gpio104",
> + "gpio105", "gpio106", "gpio107",
> };
>
> static const char * const qdss_stm_groups[] = {
> --
> 2.25.1
>
prev parent reply other threads:[~2021-05-31 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 8:28 [PATCH] pinctrl: qcom: Fix duplication in gpio_groups Manivannan Sadhasivam
2021-05-31 5:07 ` Vinod Koul
2021-05-31 16:00 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLUIF84u6VjHyNnp@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.