From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE0E1C47080 for ; Mon, 31 May 2021 17:19:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0A3D610E7 for ; Mon, 31 May 2021 17:19:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233285AbhEaRUl (ORCPT ); Mon, 31 May 2021 13:20:41 -0400 Received: from mail.skyhub.de ([5.9.137.197]:48756 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232715AbhEaRUJ (ORCPT ); Mon, 31 May 2021 13:20:09 -0400 Received: from zn.tnic (p200300ec2f080f00c524a4d22cb87212.dip0.t-ipconnect.de [IPv6:2003:ec:2f08:f00:c524:a4d2:2cb8:7212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E2CF11EC0589; Mon, 31 May 2021 19:18:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622481503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Izzz+MpnHaHiczxXxkzMFrftlLiyI7UtOOQBxR+8pYc=; b=ClHGdnkHlbDM5buNWj/jtuAHzExgHtyWWWw/Si9+MHLeLfd8UWeWiyPk0d0AKRdETU7NbR tfknJ7+dEzxdzkEJm9KkDXJ3abSsdtf4qjlUJqkb24vM01I9tmwVldMIPd5E93e881QzcY gP8e2z5RbsbzPmaUlC8swKUdw/h7dC8= Date: Mon, 31 May 2021 19:18:16 +0200 From: Borislav Petkov To: Andrew Cooper Cc: LKML , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , x86@kernel.org, "H. Peter Anvin" , Pu Wen , Tom Lendacky , Yazen Ghannam , Joerg Roedel Subject: Re: [PATCH] perf/x86/rapl: Use CPUID bit on AMD and Hygon parts Message-ID: References: <20210514135920.16093-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210514135920.16093-1-andrew.cooper3@citrix.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 02:59:20PM +0100, Andrew Cooper wrote: > diff --git a/arch/x86/kernel/cpu/powerflags.c b/arch/x86/kernel/cpu/powerflags.c > index fd6ec2aa0303..e2055f51342e 100644 > --- a/arch/x86/kernel/cpu/powerflags.c > +++ b/arch/x86/kernel/cpu/powerflags.c > @@ -21,4 +21,6 @@ const char *const x86_power_flags[32] = { > "eff_freq_ro", /* Readonly aperf/mperf */ > "proc_feedback", /* processor feedback interface */ > "acc_power", /* accumulated power mechanism */ > + "conn_standby", /* Connected Standby */ > + "rapl", /* Runtime Average Power Limit */ Yeah, so this repeats the "rapl" bit and that "conn_standby" is probably not gonna be used. Unless you have a really good reason to add that hunk, I'll whack it before applying and let this "power management" thing in /proc/cpuinfo die unchanged. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette