From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85A4C47080 for ; Tue, 1 Jun 2021 22:43:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 302CD613BC for ; Tue, 1 Jun 2021 22:43:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 302CD613BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=astier.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF5836EB23; Tue, 1 Jun 2021 22:43:17 +0000 (UTC) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6860C6EB23 for ; Tue, 1 Jun 2021 22:43:15 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id g17so206180wrs.13 for ; Tue, 01 Jun 2021 15:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=astier-eu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=raFJDnqbgQffbni8cDqTXKBGaMGmBnwdhZuZ4furOas=; b=PBML801JMX/hN5wMJZpa3YXKvlTCQdjD/hVejz4WNXph7LUicuZjJEy68H56jOSB6b FEORY55Jw6QaN4DIB1OgKLOZ6M3TU6OGOd5xsn0G8jEOuPPWUvJRC9l8iyKT+798gcPI xu+ECeyenJOyW4+xSzUNehG1ZtTKgCrevFXH69gF/3lQQ+qPhjHqQ8iiOkrcj3/Gpe0V Bi4MopTXhRW/who5oddgLI1tevkw2QtR8qfbRoS+ueMT71jUwPzEIbw/So3uGq5nvHUW TPf09w7dURkvq1i+LnlH46yENmoDgL4nL3YmjO3+5/Bd/oimB9fR2r01lyDMrxy+PkIs BLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=raFJDnqbgQffbni8cDqTXKBGaMGmBnwdhZuZ4furOas=; b=UxpMCQtdXl09B7bLU9+wTVfAGZUQA8tWgDJz44uQ3Ku7hSQ19jmhnHTEeIT8sP2nzl bqwGS9mn5exyt53ZJs6nhmbD3J7tPQjfUO41N9NkLAiB0VAheDcw8iOGW8EvUnqysio5 TUtOQnxWvfTgAoZg1hFLe+AvYsaCUJZJd8ssfG7Ddiu/X1JeLWKkvMVHJRH7KdOh1IQ0 d3MFTk2qW8HkjTzF74cjIRvtI6t45L9qxkFXayZsRBKKQnenZ0IzBcsZRr8Tr/sNSTjs 24vwkX5AC32E/nmEMbgpaxcyulS5uWT7jA+7UdT6OWQw3iNcW8cBC4NtoLFzAFO7A1P7 gd8Q== X-Gm-Message-State: AOAM531pd8IamCshTwe09pCeJJGLp8QGs7RP0GM3NMsVRcNkyR6lQqC2 42d55OvecOAz4gWoD/LER0zKCw== X-Google-Smtp-Source: ABdhPJwodA6g8jsn7Q1onsK/KORLTKnjf6z4nY0MCi5ZViExSRl1KOCI/JeY1jD+fz1f5FRqVen0NQ== X-Received: by 2002:adf:fe86:: with SMTP id l6mr25045058wrr.106.1622587394303; Tue, 01 Jun 2021 15:43:14 -0700 (PDT) Received: from bilrost ([2a01:e0a:806:8950:dea6:32ff:fe0d:99f9]) by smtp.gmail.com with ESMTPSA id n13sm5109915wrg.75.2021.06.01.15.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 15:43:13 -0700 (PDT) Date: Wed, 2 Jun 2021 00:43:11 +0200 From: Anisse Astier To: Ville Syrj?l? Message-ID: References: <20210531204642.4907-1-anisse@astier.eu> <20210531204642.4907-2-anisse@astier.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Dadap , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : > On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > used for the embedded display. Add support for using it via by adding > > the EDID to the list of available modes on the connector, and use it for > > eDP when available. > > > > If a panel's EDID is broken, there may be an override EDID set in the > > ACPI OpRegion mailbox #5. Use it if available. > > Looks like Windows uses the ACPI _DDC method instead. We should probably > do the same, just in case some crazy machine stores the EDID somewhere > else. Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a patch series to do just that, in a generic way: https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method on most devices, but without any EDID being returned. I looked at the disassembled ACPI tables[2], and could not find any device with the _DDC method. Are you sure it's the only method the Windows driver uses to get the EDID ? Regards, Anisse [1] _DOD ids should only use 16 lower bits, see table here: https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter [2] acpidump: https://gitlab.freedesktop.org/drm/intel/-/issues/3454#note_913970 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF18AC4708F for ; Tue, 1 Jun 2021 22:43:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A212613BC for ; Tue, 1 Jun 2021 22:43:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A212613BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=astier.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBD026E0F3; Tue, 1 Jun 2021 22:43:17 +0000 (UTC) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 679786E0F3 for ; Tue, 1 Jun 2021 22:43:15 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id m18so252492wrv.2 for ; Tue, 01 Jun 2021 15:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=astier-eu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=raFJDnqbgQffbni8cDqTXKBGaMGmBnwdhZuZ4furOas=; b=PBML801JMX/hN5wMJZpa3YXKvlTCQdjD/hVejz4WNXph7LUicuZjJEy68H56jOSB6b FEORY55Jw6QaN4DIB1OgKLOZ6M3TU6OGOd5xsn0G8jEOuPPWUvJRC9l8iyKT+798gcPI xu+ECeyenJOyW4+xSzUNehG1ZtTKgCrevFXH69gF/3lQQ+qPhjHqQ8iiOkrcj3/Gpe0V Bi4MopTXhRW/who5oddgLI1tevkw2QtR8qfbRoS+ueMT71jUwPzEIbw/So3uGq5nvHUW TPf09w7dURkvq1i+LnlH46yENmoDgL4nL3YmjO3+5/Bd/oimB9fR2r01lyDMrxy+PkIs BLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=raFJDnqbgQffbni8cDqTXKBGaMGmBnwdhZuZ4furOas=; b=Ah1sNUoyqzKbPLnE2JPMcwPTtk71pNG97OOIPZtsPEGzxmcQz9TaPm+5GKMjPojfIr GTcWdruOeUC59ofFatp6BkQSPnwldupJ3d+daNFZ1O/XK5VPZIf6Tw7y5wn0AqK6EBpT /RvlZ5vHbtSFaQjAbC2PO/Bkh1Rr1dkiNj5T/3/dH2aIiZK1j0gGTKNA7HZ8YHvCu8JP j05pUxBltcwybhjAk1oHTf2d+u0J052v62jETsKk2+rWTwJ0/X9zNFfVMMe12uOrgTOo C9fmUETefM7Dzh0aJG+oQAvjf+h6y3/YD1LbAUCb9m6r+ILpV7ZnAuBLsu1kLc6OU6l6 Arzw== X-Gm-Message-State: AOAM531MIZeDM4Sy3fU8P7O+Nv/EP6CsMfDwyx95SM/0uVwlHXuVJWNa GjbykarAchRRsBydZYuN7ohltg== X-Google-Smtp-Source: ABdhPJwodA6g8jsn7Q1onsK/KORLTKnjf6z4nY0MCi5ZViExSRl1KOCI/JeY1jD+fz1f5FRqVen0NQ== X-Received: by 2002:adf:fe86:: with SMTP id l6mr25045058wrr.106.1622587394303; Tue, 01 Jun 2021 15:43:14 -0700 (PDT) Received: from bilrost ([2a01:e0a:806:8950:dea6:32ff:fe0d:99f9]) by smtp.gmail.com with ESMTPSA id n13sm5109915wrg.75.2021.06.01.15.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 15:43:13 -0700 (PDT) Date: Wed, 2 Jun 2021 00:43:11 +0200 From: Anisse Astier To: Ville Syrj?l? Subject: Re: [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID Message-ID: References: <20210531204642.4907-1-anisse@astier.eu> <20210531204642.4907-2-anisse@astier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Dadap , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Hans de Goede , Uma Shankar Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : > On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > used for the embedded display. Add support for using it via by adding > > the EDID to the list of available modes on the connector, and use it for > > eDP when available. > > > > If a panel's EDID is broken, there may be an override EDID set in the > > ACPI OpRegion mailbox #5. Use it if available. > > Looks like Windows uses the ACPI _DDC method instead. We should probably > do the same, just in case some crazy machine stores the EDID somewhere > else. Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a patch series to do just that, in a generic way: https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method on most devices, but without any EDID being returned. I looked at the disassembled ACPI tables[2], and could not find any device with the _DDC method. Are you sure it's the only method the Windows driver uses to get the EDID ? Regards, Anisse [1] _DOD ids should only use 16 lower bits, see table here: https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter [2] acpidump: https://gitlab.freedesktop.org/drm/intel/-/issues/3454#note_913970