From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Input: elants_i2c - Fix NULL dereference at probing
Date: Tue, 1 Jun 2021 21:14:22 -0700 [thread overview]
Message-ID: <YLcFno/z0+XtAI3a@google.com> (raw)
In-Reply-To: <20210528071024.26450-1-tiwai@suse.de>
On Fri, May 28, 2021 at 09:10:23AM +0200, Takashi Iwai wrote:
> The recent change in elants_i2c driver to support more chips
> introduced a regression leading to Oops at probing. The driver reads
> id->driver_data, but the id may be NULL depending on the device type
> the driver gets bound.
>
> Replace the driver data extraction with the device_get_match_data()
> helper, and define the driver data in OF table, too.
>
> Fixes: 9517b95bdc46 ("Input: elants_i2c - add support for eKTF3624")
> BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1186454
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-06-02 4:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 7:10 [PATCH v3 1/2] Input: elants_i2c - Fix NULL dereference at probing Takashi Iwai
2021-05-28 7:10 ` [PATCH v3 2/2] Input: elants_i2c - Switch to probe_new Takashi Iwai
2021-06-02 4:14 ` Dmitry Torokhov
2021-06-02 4:14 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLcFno/z0+XtAI3a@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.