From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56701C4708F for ; Wed, 2 Jun 2021 05:59:34 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06E256138C for ; Wed, 2 Jun 2021 05:59:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06E256138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C63BA82E69; Wed, 2 Jun 2021 05:59:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cEpxarX0cGCJ; Wed, 2 Jun 2021 05:59:33 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTP id 7089B82AEF; Wed, 2 Jun 2021 05:59:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4540DC000E; Wed, 2 Jun 2021 05:59:32 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 75AC0C0001 for ; Wed, 2 Jun 2021 05:59:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5D28882A9D for ; Wed, 2 Jun 2021 05:59:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aDiYAph0v8Gw for ; Wed, 2 Jun 2021 05:59:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.osuosl.org (Postfix) with ESMTPS id AE0EF82A7F for ; Wed, 2 Jun 2021 05:59:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AB97D61027; Wed, 2 Jun 2021 05:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622613570; bh=WFGn28PIenT8iwgpyo1Uh1UYGjMQG1gWUpqwqXSvJlk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PfDD9zftySnlohgnH0popDk3aWgGYjbEafnbJopaPd7jvH+1yCL5jnQgWlZ2ahGI/ 34+u5QMuxWSbIYs+srYytLppF3vvE37DCrQquvxNh6bFaEUvCVJuvNVol36aXBnXd9 2+V11/33toVh4lB/DD3MH/exJbS8sHyeTWICoCjUXdNtaHyPnXYTiUYG59NWugIJuk tEboug6LCa/Y5ByPtTBuFNgq9A2g5pbrmZpCbuW6Hr9o7nkHNglUBqVy009PIYUkvD dhlkBkRWpo5G+bN9nSd9y2mbpvEf9H6yCrMiSqRsQuPMyaM/9V4L9K44Dgz2mmvkdF ota0lbaMbWaLQ== Date: Wed, 2 Jun 2021 08:59:26 +0300 From: Leon Romanovsky To: Jason Wang Subject: Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead Message-ID: References: <20210518055336-mutt-send-email-mst@kernel.org> <4aaf5125-ce75-c72a-4b4a-11c91cb85a72@linux.alibaba.com> <72f284c6-b2f5-a395-a68f-afe801eb81be@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <72f284c6-b2f5-a395-a68f-afe801eb81be@redhat.com> Cc: "Michael S. Tsirkin" , Xianting Tian , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kuba@kernel.org, davem@davemloft.net X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBNYXkgMjUsIDIwMjEgYXQgMDI6MTk6MDNQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiDlnKggMjAyMS81LzE5IOS4i+WNiDEwOjE4LCBYaWFudGluZyBUaWFuIOWGmemBkzoK PiA+IHRoYW5rcywgSSBzdWJtaXQgdGhlIHBhdGNoIGFzIGNvbW1lbnRlZCBieSBBbmRyZXcKPiA+ IGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDIxLzUvMTgvMjU2Cj4gPiAKPiA+IEFjdHVhbGx5LCBp ZiB4bWl0X3NrYigpIHJldHVybnMgZXJyb3IsIGJlbG93IGNvZGUgd2lsbCBnaXZlIGEgd2Fybmlu Zwo+ID4gd2l0aCBlcnJvciBjb2RlLgo+ID4gCj4gPiDCoMKgwqDCoC8qIFRyeSB0byB0cmFuc21p dCAqLwo+ID4gwqDCoMKgwqBlcnIgPSB4bWl0X3NrYihzcSwgc2tiKTsKPiA+IAo+ID4gwqDCoMKg wqAvKiBUaGlzIHNob3VsZCBub3QgaGFwcGVuISAqLwo+ID4gwqDCoMKgwqBpZiAodW5saWtlbHko ZXJyKSkgewo+ID4gwqDCoMKgwqDCoMKgwqAgZGV2LT5zdGF0cy50eF9maWZvX2Vycm9ycysrOwo+ ID4gwqDCoMKgwqDCoMKgwqAgaWYgKG5ldF9yYXRlbGltaXQoKSkKPiA+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgZGV2X3dhcm4oJmRldi0+ZGV2LAo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgIlVuZXhwZWN0ZWQgVFhRICglZCkgcXVldWUgZmFpbHVyZTogJWRcbiIsCj4gPiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBxbnVtLCBlcnIpOwo+ID4gwqDCoMKgwqDC oMKgwqAgZGV2LT5zdGF0cy50eF9kcm9wcGVkKys7Cj4gPiDCoMKgwqDCoMKgwqDCoCBkZXZfa2Zy ZWVfc2tiX2FueShza2IpOwo+ID4gwqDCoMKgwqDCoMKgwqAgcmV0dXJuIE5FVERFVl9UWF9PSzsK PiA+IMKgwqDCoMKgfQo+ID4gCj4gPiAKPiA+IAo+ID4gCj4gPiAKPiA+IOWcqCAyMDIxLzUvMTgg 5LiL5Y2INTo1NCwgTWljaGFlbCBTLiBUc2lya2luIOWGmemBkzoKPiA+ID4gdHlwbyBpbiBzdWJq ZWN0Cj4gPiA+IAo+ID4gPiBPbiBUdWUsIE1heSAxOCwgMjAyMSBhdCAwNTo0Njo1NlBNICswODAw LCBYaWFudGluZyBUaWFuIHdyb3RlOgo+ID4gPiA+IFdoZW4gbWV0IGVycm9yLCB3ZSBvdXRwdXQg YSBwcmludCB0byBhdm9pZCBhIEJVRygpLgo+IAo+IAo+IFNvIHlvdSBkb24ndCBleHBsYWluIHdo eSB5b3UgbmVlZCB0byByZW1vdmUgQlVHKCkuIEkgdGhpbmsgaXQgZGVzZXJ2ZSBhCj4gQlVHKCku CgpCVUcoKSB3aWxsIGNyYXNoIHRoZSBtYWNoaW5lIGFuZCB2aXJ0aW9fbmV0IGlzIG5vdCBrZXJu ZWwgY29yZQpmdW5jdGlvbmFsaXR5IHRoYXQgbXVzdCBzdG9wIHRoZSBtYWNoaW5lIHRvIHByZXZl bnQgYW55dGhpbmcgdHJ1bHkKaGFybWZ1bCBhbmQgYmFzaWMuCgpJIHdvdWxkIGFyZ3VlIHRoYXQg Y29kZSBpbiBkcml2ZXJzLyogc2hvdWxkbid0IGNhbGwgQlVHKCkgbWFjcm9zIGF0IGFsbC4KCklm IGl0IGlzIGltcG9zc2libGUsIGRvbid0IGNoZWNrIGZvciB0aGF0IG9yIGFkZCBXQVJOX09OKCkg YW5kIHJlY292ZXIsCmJ1dCBkb24ndCBjcmFzaCB3aG9sZSBzeXN0ZW0uCgpUaGFua3MKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24g bWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0 dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxp emF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8629C4708F for ; Wed, 2 Jun 2021 05:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A076761360 for ; Wed, 2 Jun 2021 05:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbhFBGBP (ORCPT ); Wed, 2 Jun 2021 02:01:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:48308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbhFBGBM (ORCPT ); Wed, 2 Jun 2021 02:01:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB97D61027; Wed, 2 Jun 2021 05:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622613570; bh=WFGn28PIenT8iwgpyo1Uh1UYGjMQG1gWUpqwqXSvJlk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PfDD9zftySnlohgnH0popDk3aWgGYjbEafnbJopaPd7jvH+1yCL5jnQgWlZ2ahGI/ 34+u5QMuxWSbIYs+srYytLppF3vvE37DCrQquvxNh6bFaEUvCVJuvNVol36aXBnXd9 2+V11/33toVh4lB/DD3MH/exJbS8sHyeTWICoCjUXdNtaHyPnXYTiUYG59NWugIJuk tEboug6LCa/Y5ByPtTBuFNgq9A2g5pbrmZpCbuW6Hr9o7nkHNglUBqVy009PIYUkvD dhlkBkRWpo5G+bN9nSd9y2mbpvEf9H6yCrMiSqRsQuPMyaM/9V4L9K44Dgz2mmvkdF ota0lbaMbWaLQ== Date: Wed, 2 Jun 2021 08:59:26 +0300 From: Leon Romanovsky To: Jason Wang Cc: Xianting Tian , "Michael S. Tsirkin" , davem@davemloft.net, kuba@kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead Message-ID: References: <20210518055336-mutt-send-email-mst@kernel.org> <4aaf5125-ce75-c72a-4b4a-11c91cb85a72@linux.alibaba.com> <72f284c6-b2f5-a395-a68f-afe801eb81be@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <72f284c6-b2f5-a395-a68f-afe801eb81be@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 02:19:03PM +0800, Jason Wang wrote: > > 在 2021/5/19 下午10:18, Xianting Tian 写道: > > thanks, I submit the patch as commented by Andrew > > https://lkml.org/lkml/2021/5/18/256 > > > > Actually, if xmit_skb() returns error, below code will give a warning > > with error code. > > > >     /* Try to transmit */ > >     err = xmit_skb(sq, skb); > > > >     /* This should not happen! */ > >     if (unlikely(err)) { > >         dev->stats.tx_fifo_errors++; > >         if (net_ratelimit()) > >             dev_warn(&dev->dev, > >                  "Unexpected TXQ (%d) queue failure: %d\n", > >                  qnum, err); > >         dev->stats.tx_dropped++; > >         dev_kfree_skb_any(skb); > >         return NETDEV_TX_OK; > >     } > > > > > > > > > > > > 在 2021/5/18 下午5:54, Michael S. Tsirkin 写道: > > > typo in subject > > > > > > On Tue, May 18, 2021 at 05:46:56PM +0800, Xianting Tian wrote: > > > > When met error, we output a print to avoid a BUG(). > > > So you don't explain why you need to remove BUG(). I think it deserve a > BUG(). BUG() will crash the machine and virtio_net is not kernel core functionality that must stop the machine to prevent anything truly harmful and basic. I would argue that code in drivers/* shouldn't call BUG() macros at all. If it is impossible, don't check for that or add WARN_ON() and recover, but don't crash whole system. Thanks