From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
peterz@infradead.org, rjw@rjwysocki.net, viresh.kumar@linaro.org,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
vincent.donnefort@arm.com, mingo@redhat.com,
juri.lelli@redhat.com, rostedt@goodmis.org, segall@google.com,
mgorman@suse.de, bristot@redhat.com
Subject: Re: [PATCH 1/2] sched/fair: Take thermal pressure into account while estimating energy
Date: Wed, 2 Jun 2021 15:00:48 +0000 [thread overview]
Message-ID: <YLedIMNFlZ5eu2Oe@google.com> (raw)
In-Reply-To: <20210602135609.10867-2-lukasz.luba@arm.com>
Hi Lukasz,
On Wednesday 02 Jun 2021 at 14:56:08 (+0100), Lukasz Luba wrote:
> compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> {
> struct cpumask *pd_mask = perf_domain_span(pd);
> - unsigned long cpu_cap = arch_scale_cpu_capacity(cpumask_first(pd_mask));
> + unsigned long _cpu_cap = arch_scale_cpu_capacity(cpumask_first(pd_mask));
> unsigned long max_util = 0, sum_util = 0;
> + unsigned long cpu_cap = _cpu_cap;
> int cpu;
>
> /*
> @@ -6558,6 +6559,14 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> cpu_util_next(cpu, p, -1) + task_util_est(p);
> }
>
> + /*
> + * Take the thermal pressure from non-idle CPUs. They have
> + * most up-to-date information. For idle CPUs thermal pressure
> + * signal is not updated so often.
> + */
> + if (!idle_cpu(cpu))
> + cpu_cap = _cpu_cap - thermal_load_avg(cpu_rq(cpu));
This messes up the irq time scaling no? Maybe move the capping in this
function instead of relying on effective_cpu_util() to do it for you?
> /*
> * Busy time computation: utilization clamping is not
> * required since the ratio (sum_util / cpu_capacity)
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-06-02 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:56 [PATCH 0/2] Add allowed CPU capacity knowledge to EAS Lukasz Luba
2021-06-02 13:56 ` [PATCH 1/2] sched/fair: Take thermal pressure into account while estimating energy Lukasz Luba
2021-06-02 15:00 ` Quentin Perret [this message]
2021-06-02 15:35 ` Lukasz Luba
2021-06-02 13:56 ` [PATCH 2/2] sched/cpufreq: Consider reduced CPU capacity in energy calculation Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLedIMNFlZ5eu2Oe@google.com \
--to=qperret@google.com \
--cc=bristot@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=segall@google.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.