From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE2EC47082 for ; Thu, 3 Jun 2021 08:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB79E613E3 for ; Thu, 3 Jun 2021 08:49:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbhFCIvW (ORCPT ); Thu, 3 Jun 2021 04:51:22 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:40568 "EHLO mail-ed1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFCIvV (ORCPT ); Thu, 3 Jun 2021 04:51:21 -0400 Received: by mail-ed1-f53.google.com with SMTP id t3so6171366edc.7 for ; Thu, 03 Jun 2021 01:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=vPAp0cDqkozZvEWRxxBHH5RxVtokOPhreu0KnKBlDT8=; b=Dfc5iwcBu7xHR6cCUm7AXpRC3Am+2tgSjO2cK3b+y81daO+VUcDnqv5aiqhlX2f8ET 6onChdoAnMmIk5UTlu73QIpDDtNnf1X2MUG0IL1DmsIJFdqoA6heSynaLiB8Ryp9ysYy aHhDS1NSxmydVwhy0JCxhpd7kO6T0dhC7iCfU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=vPAp0cDqkozZvEWRxxBHH5RxVtokOPhreu0KnKBlDT8=; b=aVuLCnWO9agtH25cnJJkfY+z+8cUNS+iU2EeDpuJnPPyIAVV5swdoVBu33Dptaq6fc rcnrBzJJfwN3Jgh2HLnhwI0oeLGPoZSP3qONGE7ENfAURIrRuEmnDpWHYfbBQqbeETFn s5F988V/UOKkALjSFK3yJBuC3NENVtMwhwIxv1MPUgvSQvwIpnFGWJM+UT4ekHm76I1U YG8ZiyK7DNOEbldsOlel1edsiuMy32LHYIxcJ/EmuQmvVcpfj3y7ZzUBpoysxJ6fv6Yv CaZKdLYn4u8BuTc3E7C7YJYRwXIezyBKyrSbRxVPDLczASt+3KAdOQ7RdJEd4aDY+WxA 9RmQ== X-Gm-Message-State: AOAM532UVMcUln3VB5HEjwxek66T1Pk5V2paiOUnMTQAVJc/5KxwcLWO JSzI7sJdXBvV/XT5UITEjVROyA== X-Google-Smtp-Source: ABdhPJwv4djZniG7P4/1rgxf9Fevn796Yj3QoQ3lNQh0vjHJ+sYM0uCv+TLIpzDfNoN6sGHi5HwO+Q== X-Received: by 2002:aa7:dd57:: with SMTP id o23mr42071917edw.98.1622710116626; Thu, 03 Jun 2021 01:48:36 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z17sm1232609ejc.69.2021.06.03.01.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 01:48:36 -0700 (PDT) Date: Thu, 3 Jun 2021 10:48:33 +0200 From: Daniel Vetter To: Kees Cook Cc: Dave Airlie , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , kernel test robot , Sai Prakash Ranjan , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Rob Herring , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB Message-ID: Mail-Followup-To: Kees Cook , Dave Airlie , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , kernel test robot , Sai Prakash Ranjan , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Rob Herring , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20210602215252.695994-1-keescook@chromium.org> <20210602215252.695994-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210602215252.695994-2-keescook@chromium.org> X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jun 02, 2021 at 02:52:50PM -0700, Kees Cook wrote: > When cleaning up other drm config dependencies, it is too easy to create > larger problems. Instead, mark CONFIG_FB as a "depends": > > drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! > > Suggested-by: Arnd Bergmann > Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ > Signed-off-by: Kees Cook I rebased this one for -next and applied all three patches to drm-misc-next. -Daniel > --- > drivers/gpu/drm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 3c16bd1afd87..90891284ccec 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -83,7 +83,7 @@ config DRM_KMS_HELPER > config DRM_KMS_FB_HELPER > bool > depends on DRM_KMS_HELPER > - select FB > + depends on FB > select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > select FB_SYS_FOPS > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998AAC47096 for ; Thu, 3 Jun 2021 08:48:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AF18613DE for ; Thu, 3 Jun 2021 08:48:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AF18613DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD1276F455; Thu, 3 Jun 2021 08:48:38 +0000 (UTC) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by gabe.freedesktop.org (Postfix) with ESMTPS id E187D6F455 for ; Thu, 3 Jun 2021 08:48:37 +0000 (UTC) Received: by mail-ed1-x52a.google.com with SMTP id f5so1176071eds.0 for ; Thu, 03 Jun 2021 01:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=vPAp0cDqkozZvEWRxxBHH5RxVtokOPhreu0KnKBlDT8=; b=Dfc5iwcBu7xHR6cCUm7AXpRC3Am+2tgSjO2cK3b+y81daO+VUcDnqv5aiqhlX2f8ET 6onChdoAnMmIk5UTlu73QIpDDtNnf1X2MUG0IL1DmsIJFdqoA6heSynaLiB8Ryp9ysYy aHhDS1NSxmydVwhy0JCxhpd7kO6T0dhC7iCfU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=vPAp0cDqkozZvEWRxxBHH5RxVtokOPhreu0KnKBlDT8=; b=piA7Tx20hEIrhdeaTrOdiJ/qYiFw+5uN09N8EFl1Gvt3gOXjHkc9JersfcaCGhvUEi ppJQyj/B1LN8ZWPHygWOx57rSgFrm1+F/gBfwwb8+PYepY8yacIHDGdwycamPaHrB20o BFrpUDzv3um6V3J03tOUD1Hkal0DpZMJlaBY8wmTndmciHho0klVkMLlN7zE48dqRO3r iWis6mPIp5swOrRopFirRKpmBqtEohlVBkPJzBV9M3RGOw4pbkwXs/05Umiapg7wjA8B u4R7opuT+8/Ymeo5xXyYIoK3ZyyjLSZ/mJhkqR/rwLzlX2Yn15V6frM+4x3/MmEtJNjy YYDA== X-Gm-Message-State: AOAM533TwFuG7HnX9T+JZKa9Qb/qx3ntWfvynoJ6YIhQN3XSGVvla6mH TC+GZiRaH/N3I3p4ef+cvDeYsw== X-Google-Smtp-Source: ABdhPJwv4djZniG7P4/1rgxf9Fevn796Yj3QoQ3lNQh0vjHJ+sYM0uCv+TLIpzDfNoN6sGHi5HwO+Q== X-Received: by 2002:aa7:dd57:: with SMTP id o23mr42071917edw.98.1622710116626; Thu, 03 Jun 2021 01:48:36 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z17sm1232609ejc.69.2021.06.03.01.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 01:48:36 -0700 (PDT) Date: Thu, 3 Jun 2021 10:48:33 +0200 From: Daniel Vetter To: Kees Cook Subject: Re: [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB Message-ID: Mail-Followup-To: Kees Cook , Dave Airlie , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , kernel test robot , Sai Prakash Ranjan , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Rob Herring , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20210602215252.695994-1-keescook@chromium.org> <20210602215252.695994-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210602215252.695994-2-keescook@chromium.org> X-Operating-System: Linux phenom 5.10.32scarlett+ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Sai Prakash Ranjan , Emma Anholt , David Airlie , Sam Ravnborg , Sharat Masetty , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , linux-arm-msm@vger.kernel.org, Dave Airlie , freedreno@lists.freedesktop.org, Sean Paul , kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jun 02, 2021 at 02:52:50PM -0700, Kees Cook wrote: > When cleaning up other drm config dependencies, it is too easy to create > larger problems. Instead, mark CONFIG_FB as a "depends": > > drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! > > Suggested-by: Arnd Bergmann > Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ > Signed-off-by: Kees Cook I rebased this one for -next and applied all three patches to drm-misc-next. -Daniel > --- > drivers/gpu/drm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 3c16bd1afd87..90891284ccec 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -83,7 +83,7 @@ config DRM_KMS_HELPER > config DRM_KMS_FB_HELPER > bool > depends on DRM_KMS_HELPER > - select FB > + depends on FB > select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > select FB_SYS_FOPS > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch