From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85348C47425 for ; Fri, 4 Jun 2021 16:34:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E0BF610E7 for ; Fri, 4 Jun 2021 16:34:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E0BF610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7BCAD6B0073; Fri, 4 Jun 2021 12:34:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 745BA6B0082; Fri, 4 Jun 2021 12:34:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BF816B0085; Fri, 4 Jun 2021 12:34:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 267246B0073 for ; Fri, 4 Jun 2021 12:34:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BC9A311215 for ; Fri, 4 Jun 2021 16:34:55 +0000 (UTC) X-FDA: 78216590550.01.15101FD Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf28.hostedemail.com (Postfix) with ESMTP id 7F3E4200112D for ; Fri, 4 Jun 2021 16:34:38 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id t9so8320805pgn.4 for ; Fri, 04 Jun 2021 09:34:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WmER0sPmJ9ixY8p+WTTY2FhzPf3j9TTlXo0+cEHTCt4=; b=FML4xUSqm0pvDJQ6aeXEgrMK6nmsv0IAI7+D//1xEp2nQqIqNq0dzM8b4XhBmNOPbS EzAg998gUvdMGzXgJtXCh/OqYERn9iBwoBax01COYsnx6EkNHF9by0EtAHTEIpazx6Wr +87Hs0TwAQ2d1nv07CbC2pq2BpYqOfxdFzRkdQ79kSzg8Lc9Sdzu36F2ZdPBZUsHjc7U udYlDNDoTYh+o7ZPkASq4XxI3ORV2rMGffkRKdSrEvS926mMW+HLj4+0TbZVKOWwfn0p GXLWliApZHDtX/rN8LEVRuf24TKQBGgldWU/7b76+R6nSFOShu3hCTH1Xoen7/rX3iYI voKw== X-Gm-Message-State: AOAM532dQ4xJMl6Zgg/NMUx6O6QAyJi+K3f36cb40gsa9O61LSSGj1My gI7UOLL2I/YAoLtSrQKqE0vZR37wCgo= X-Google-Smtp-Source: ABdhPJzjiFSZ+MTAsRkaXfWKrteXuc2CVIWEYgOef8GmeTjnECm7PQkB5cw0yvFlGpZcgn6vdIVC4Q== X-Received: by 2002:a92:cecd:: with SMTP id z13mr4491352ilq.252.1622823047849; Fri, 04 Jun 2021 09:10:47 -0700 (PDT) Received: from google.com (243.199.238.35.bc.googleusercontent.com. [35.238.199.243]) by smtp.gmail.com with ESMTPSA id c19sm691087ili.62.2021.06.04.09.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 09:10:47 -0700 (PDT) Date: Fri, 4 Jun 2021 16:10:46 +0000 From: Dennis Zhou To: Roman Gushchin Cc: Tejun Heo , Christoph Lameter , Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] percpu: memcg memory accounting rework Message-ID: References: <20210603010931.1472512-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210603010931.1472512-1-guro@fb.com> X-Stat-Signature: i4gr4jmgej6sn3ze1pd3qyy4fqcpig46 X-Rspamd-Queue-Id: 7F3E4200112D X-Rspamd-Server: rspam02 Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf28.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-HE-Tag: 1622824478-674668 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Wed, Jun 02, 2021 at 06:09:28PM -0700, Roman Gushchin wrote: > This patchset reworks memcg-based accounting of the percpu memory: > instead of using two types of chunks (memcg-aware and non-memcg-aware) > it treats all chunks as memcg-aware. An extra memory used for objcg > arrays will is compensated by a better chunks utilization, so the > total memory footprint should be the same or smaller. > > First two patches are preparational changes and cleanups on the memcg side. > The third one is percpu accounting rework. > > v2: > - make all chunks memcg-aware instead of on-demand objcg allocation, by Dennis > > v1: > https://lkml.org/lkml/2021/5/11/1343 > > > Roman Gushchin (3): > mm, memcg: mark cgroup_memory_nosocket, nokmem and noswap as > __ro_after_init > mm, memcg: introduce mem_cgroup_kmem_disabled() > percpu: rework memcg accounting > > include/linux/memcontrol.h | 5 ++ > mm/memcontrol.c | 11 ++- > mm/percpu-internal.h | 52 +-------------- > mm/percpu-km.c | 5 +- > mm/percpu-stats.c | 46 +++++-------- > mm/percpu-vm.c | 11 ++- > mm/percpu.c | 133 +++++++++++++++---------------------- > 7 files changed, 88 insertions(+), 175 deletions(-) > > -- > 2.31.1 > I think I'm pretty happy with this approach. If there is any issue with the delta of memcg on but kmem accounting off, we can tackle that separately. I'll need another day or so to review the last patch a little more carefully though. Andrew do you mind if I route the first two in my tree too? Thanks, Dennis