All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Sean Christopherson <seanjc@google.com>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] notifier: Return non-null when callback is already registered
Date: Fri, 4 Jun 2021 18:48:35 +0200	[thread overview]
Message-ID: <YLpZY3fSYvcefzS6@zn.tnic> (raw)
In-Reply-To: <YLpYbQnswxZUB5sW@google.com>

On Fri, Jun 04, 2021 at 04:44:29PM +0000, Sean Christopherson wrote:
> The WARN is still going to make that "necessary", and the vast number of callers
> and variations that don't check the return value means that WARN isn't going
> anywhere for quite some time.  Returning an error code still makes sense, but
> the changelog is misleading in that it implies callers can blindly register
> without any repercussions.

Yeah, so tglx gave me a much better idea on IRC: make that function
__must_check and drop the WARN.

I'll play with a full allmodconfig build and see what complains and
whether I can make it into a kernelnewbies project. :)

Thanks for the review anyway, I'll use some of it in the new version.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

      reply	other threads:[~2021-06-04 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 14:41 [PATCH -v2] notifier: Return non-null when callback is already registered Borislav Petkov
2021-06-04 16:44 ` Sean Christopherson
2021-06-04 16:48   ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLpZY3fSYvcefzS6@zn.tnic \
    --to=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanjc@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.