From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] doc: Modernize test-writing-guidelines
Date: Fri, 4 Jun 2021 19:00:40 +0200 [thread overview]
Message-ID: <YLpcOFM7Us0s+y87@pevik> (raw)
In-Reply-To: <20210603114208.8152-1-chrubis@suse.cz>
Hi Cyril,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM.
> -1.2 Code duplication
> -~~~~~~~~~~~~~~~~~~~~
> +* Do not write Makefiles from scratch, use LTP build system instead
> +
> +* Etc.
> +
> +
nit: sometimes you use 2 blank lines at the end of the chapter, sometimes just one.
> +1.2 Keep functions and variable names short
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kind regards,
Petr
next prev parent reply other threads:[~2021-06-04 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 11:42 [LTP] [PATCH v2] doc: Modernize test-writing-guidelines Cyril Hrubis
2021-06-04 17:00 ` Petr Vorel [this message]
2021-06-17 11:06 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2021-06-02 14:31 Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLpcOFM7Us0s+y87@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.