From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D95C47082 for ; Sat, 5 Jun 2021 05:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A60D61263 for ; Sat, 5 Jun 2021 05:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbhFEFPZ (ORCPT ); Sat, 5 Jun 2021 01:15:25 -0400 Received: from muru.com ([72.249.23.125]:36546 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbhFEFPY (ORCPT ); Sat, 5 Jun 2021 01:15:24 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 01DA98167; Sat, 5 Jun 2021 05:13:44 +0000 (UTC) Date: Sat, 5 Jun 2021 08:13:34 +0300 From: Tony Lindgren To: Jarkko Nikula Cc: linux-omap@vger.kernel.org Subject: Re: Regression with 6cfcd5563b4f on BeagleBoard Rev C2 Message-ID: References: <68f28473-a196-b106-b4ae-e9162b7002e6@bitmer.com> <5037cd3e-9c4f-0028-ceef-8315d297f2bc@bitmer.com> <3d73f5b4-dfb3-682e-e1dc-cf5feba69121@bitmer.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d73f5b4-dfb3-682e-e1dc-cf5feba69121@bitmer.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Jarkko Nikula [210604 15:41]: > On 4.6.2021 9.35, Tony Lindgren wrote: > > Hi, > > > > * Jarkko Nikula [210602 18:21]: > >> Hi > >> > >> On 6/2/21 8:30 AM, Tony Lindgren wrote: > >>> Sounds like the beagleboard timer errata handling is either picking > >>> a wrong clockevent timer, or later on ti-sysc misdetects the active > >>> timer for clockevent and idles it. > >>> > >>> What does dmesg say in the beginning for clockevent and clocksource > >>> timers? > >>> > >> I attached logs from commit 6cfcd5563b4f and commit 30c66fc30ee7 before > >> it. Perhaps this is relevant difference between them? > >> > >> +ti-sysc: probe of 49032000.target-module failed with error -16 > >> +ti-sysc: probe of 48304000.target-module failed with error -16 > > > > Yeah so it seems. We now attempt to ignore the system timer instances > > while it seems we need also block idling at least for timer12 that is > > used for the beagle timer. > > > > Can you test the following patch and see if it helps? > > > It works! I tested on top of both regressing commit and the most recent one: > 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume > for am3 and am4") > and > f88cd3fb9df2 ("Merge tag 'vfio-v5.13-rc5' of > git://github.com/awilliam/linux-vfio") > > You may add: > Tested-by: Jarkko Nikula OK good to hear, I'll send out a fix with a proper description. Regards, Tony