Re: [PATCH 5/5] build-sys: replace makefiles to wrap meson/ninja

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 4320 bytes --]

On Tue, Jun 15, 2021 at 11:19:39AM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jun 15, 2021 at 10:26 AM David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6iEOx6SR5NKn@public.gmane.orgu>
> wrote:
> 
> > On Tue, Jun 08, 2021 at 01:25:03PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Tue, Jun 8, 2021 at 7:54 AM David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6ryscVyMRj84@public.gmane.org.au
> > >
> > > wrote:
> > >
> > > > On Mon, Dec 07, 2020 at 05:00:55PM +0400, marcandre.lureau@redhat.com
> > > > wrote:
> > > > > From: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > > >
> > > > > This avoids maintaining two build systems, and update the
> > documentation.
> > > > >
> > > > > Makefile now wrap meson, so that make all/check/checkm/clean/install
> > > > > continue working as they used to.
> > > > >
> > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > >
> > > > Sorry I've neglected this so long.  I finally got around to lookup up
> > > > a cheatsheet for how to use meson "natively" to understand this
> > > > better.
> > > >
> > > > Couple of issues with this path though:
> > > >
> > > > > ---
> > > > >  Makefile                   | 380
> > ++-----------------------------------
> > > > >  Makefile.convert-dtsv0     |  14 --
> > > > >  Makefile.dtc               |  23 ---
> > > > >  Makefile.utils             |  31 ---
> > > > >  README                     |  24 ++-
> > > > >  libfdt/Makefile.libfdt     |  18 --
> > > > >  pylibfdt/Makefile.pylibfdt |  30 ---
> > > > >  tests/Makefile.tests       | 100 ----------
> > > >
> > > > First, it no longer applies clean due to some added tests.  Can you
> > > > rebase please.
> > > >
> > >
> > > Sure, https://github.com/elmarco/dtc/tree/meson-next
> > >
> > >
> > > > > +checkm:
> > > > > +     WITH_VALGRIND=1 meson test -C $(BUILD_DIR) -v
> > > >
> > > > Second, the valgrind stuff doesn't seem to work.  I tried
> > > > "WITH_VALGRIND=1 meson test" and it completes much to fast to actually
> > > > be using valgrind.  Also it doesn't give any error if valgrind isn't
> > > > installed.
> > > >
> > >
> > > Oh? I get this:
> > > /home/elmarco/src/dtc/tests/run_tests.sh: line 75: valgrind: command not
> > > found
> > >
> > > And when valgrind is installed it uses it and takes ages to complete the
> > > tests.
> >
> > Huh.  Yet for me it does not
> >
> > yekko:~/src/dtc/tmp (main)$ time meson test
> > ninja: Entering directory `/home/dwg/src/dtc/tmp'
> > [2/2] Generating pylibfdt with a custom command
> > 1/1 run-test OK             2.67s
> >
> >
> > Ok:                 1
> > Expected Fail:      0
> > Fail:               0
> > Unexpected Pass:    0
> > Skipped:            0
> > Timeout:            0
> >
> > Full log written to /home/dwg/src/dtc/tmp/meson-logs/testlog.txt
> >
> > real    0m3.015s
> > user    0m1.862s
> > sys     0m1.197s
> > yekko:~/src/dtc/tmp (main)$ time env WITH_VALGRIND=1 meson test
> > ninja: Entering directory `/home/dwg/src/dtc/tmp'
> > [2/2] Generating pylibfdt with a custom command
> > 1/1 run-test OK             2.47s
> >
> >
> > Ok:                 1
> > Expected Fail:      0
> > Fail:               0
> > Unexpected Pass:    0
> > Skipped:            0
> > Timeout:            0
> >
> > Full log written to /home/dwg/src/dtc/tmp/meson-logs/testlog.txt
> >
> > real    0m2.836s
> > user    0m1.838s
> > sys     0m1.163s
> >
> >
> > I have no idea how to debug that...
> >
> >
> What's your version of meson? There has been an environment-related
> regression in 0.58 that was quickly fixed in 0.58.1. (I tried older
> versions as well when I wrote the patch last year)

meson-0.56.2-2.fc34.noarch
ninja-build-1.10.2-2.fc34.x86_64

> You could check your environment by adding an "env" call at the top of
> run_tests.sh and checking it in build/meson-logs/testlog.txt

Tried that, and it showed the WITH_VALGRIND value.  I'm not actually
sure what's supposed to be acting on the WITH_VALGRIND variable.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]