From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA24C47095 for ; Wed, 9 Jun 2021 07:44:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E39AF61361 for ; Wed, 9 Jun 2021 07:44:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E39AF61361 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C2B0F608E4; Wed, 9 Jun 2021 07:44:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5-n6e66mGfJC; Wed, 9 Jun 2021 07:44:39 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id CC5A1608C4; Wed, 9 Jun 2021 07:44:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A96A4C000E; Wed, 9 Jun 2021 07:44:38 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2C7C5C000B for ; Wed, 9 Jun 2021 07:44:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 19E55404C3 for ; Wed, 9 Jun 2021 07:44:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6ZpxL_m7_mFw for ; Wed, 9 Jun 2021 07:44:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp4.osuosl.org (Postfix) with ESMTPS id BCE6A404B9 for ; Wed, 9 Jun 2021 07:44:36 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 4AC0436A; Wed, 9 Jun 2021 09:44:33 +0200 (CEST) Date: Wed, 9 Jun 2021 09:44:32 +0200 From: Joerg Roedel To: Zhen Lei Subject: Re: [PATCH 1/1] iommu: Delete a duplicate check in iommu_change_dev_def_domain() Message-ID: References: <20210513075815.6382-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210513075815.6382-1-thunder.leizhen@huawei.com> Cc: Sai Praneeth Prakhya , iommu , Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, May 13, 2021 at 03:58:15PM +0800, Zhen Lei wrote: > Function iommu_group_store_type() is the only caller of the static > function iommu_change_dev_def_domain() and has performed > "if (WARN_ON(!group))" detection before calling it. So the one here is > redundant. > > Signed-off-by: Zhen Lei > --- > drivers/iommu/iommu.c | 3 --- > 1 file changed, 3 deletions(-) Applied, thanks. > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 971068da67cb91d..8cdf6a1c4bfd773 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -3059,9 +3059,6 @@ static int iommu_change_dev_def_domain(struct iommu_group *group, > int ret, dev_def_dom; > struct device *dev; > > - if (!group) > - return -EINVAL; > - > mutex_lock(&group->mutex); > > if (group->default_domain != group->domain) { > -- > 2.26.0.106.g9fadedd > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu