From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-users@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
eranian@google.com, Michael Petlan <mpetlan@redhat.com>
Subject: Re: [RFC PATCH] libtraceevent: Increase libtraceevent logging when verbose
Date: Thu, 10 Jun 2021 22:47:41 +0200 [thread overview]
Message-ID: <YMJ6bUQ8yXT+uMAF@krava> (raw)
In-Reply-To: <20210610155915.20a252d3@oasis.local.home>
On Thu, Jun 10, 2021 at 03:59:15PM -0400, Steven Rostedt wrote:
> On Thu, 10 Jun 2021 21:08:32 +0200
> Jiri Olsa <jolsa@redhat.com> wrote:
>
> > Michael did the libtraceevent detection and dynamic linking support:
> > https://lore.kernel.org/linux-perf-users/20210428092023.4009-1-mpetlan@redhat.com/
> >
> > I think we should have that in Fedora/RHEL rpms already, or it's on the way.
> >
> > The detection code could be change to contain things we need.
>
> Or it can also be changed to export the version too?
>
> LIBTRACEEVENT_VERSION = $(shell pkg-config --modversion libtraceevent | perl -e '$ver=<>; @v=split /,/,$ver; printf "%d\n", $v[0] * 255 * 255 | $v[1] * 255 | $v[2];')
>
> -DLIBTRACEFS_VERSION=$(LIBTRACEEVENT_VERSION)
so the feature detection just gives out on/off answers,
but we can easily put above to perf's makefile
jirka
>
> Then in C have:
>
> #define VERSION(a,b,c) ((a)*255*255|(b)*255|(c))
>
> #if LIBTRACEEVENT_VERSION >= VERSION(1,2,3)
>
> To test if the libtraceevent feature is available?
>
> -- Steve
>
prev parent reply other threads:[~2021-06-10 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 6:06 [RFC PATCH] libtraceevent: Increase libtraceevent logging when verbose Ian Rogers
2021-06-10 14:39 ` Steven Rostedt
2021-06-10 18:50 ` Ian Rogers
2021-06-10 19:32 ` Steven Rostedt
2021-06-10 19:08 ` Jiri Olsa
2021-06-10 19:47 ` Steven Rostedt
2021-06-10 19:59 ` Steven Rostedt
2021-06-10 20:47 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMJ6bUQ8yXT+uMAF@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.