From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71022C4743D for ; Fri, 11 Jun 2021 07:22:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50F62613AE for ; Fri, 11 Jun 2021 07:22:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbhFKHYb (ORCPT ); Fri, 11 Jun 2021 03:24:31 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:38991 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229960AbhFKHYb (ORCPT ); Fri, 11 Jun 2021 03:24:31 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 33F9258049A; Fri, 11 Jun 2021 03:22:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 11 Jun 2021 03:22:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=5YiBwSdJLoDEOuRL8pQdjIm/ZNz uYm4POR9BQWZtsjM=; b=bavhkSfyRzKNkX8FNZRL8hkH9uvCbEVL6rnAIlbrJGL 2QAS0CcVBZSAY9PZMRUocXYoZwDTOSxVJjq3yIS8uTb3BXl/tCwCF2yMBDzDZCP3 +3l00ntbu3F51/ib8kFUeQiyvsJHMgG2kV8/oOkIOTH/Nw1A6XfNfMsxdCsfzfrG q/M7miFPzOyikxXedLIaY/HFHOfAB4w6wZqd8ed6GzrvcHN/ul36QiMzHZQOS6hG QoVHIjwTaXWKIVyWTk2MOk6PfOAAVxkZChCRwOg3niGAg0UbZlAtKDRyb+pUYWP8 62v7dlpKDIoLi1vm2vSf0D1UCocYeMTzHUJJLMWTxcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5YiBwS dJLoDEOuRL8pQdjIm/ZNzuYm4POR9BQWZtsjM=; b=WyXK0gwJM5S3YsE/kfzxsB XRwgEoBgE1AMNiLveVNxXX2uAHinlJT5ZfIf7d8Aq2+rg3M6BLFrJnXncp/1sEn7 mRtJ4HwPHYyXeJHaZbR2JpufP6TZnzJU/yvNRhrjkcLSr4hw1wKJg6iiJV5fAAK1 Q5eR6wgpd7wuPbqcmSnrfUIfmxBuE7WbKqHq+m6ud5iBKd6wAsMEjHaAP5mue5hq MdowuMrlKojI3odxyjty79W0b9mePGPNIxb2ZDbqzi5qWHSK8AFjBKhY3NOw1gd2 Y6VuaMZhAorKq+wkdbeTrN2u+X2cS+I7xPoSmCaFaNLHNaARJh7xlwz445IYkEWg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeduiedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Jun 2021 03:22:31 -0400 (EDT) Date: Fri, 11 Jun 2021 09:22:28 +0200 From: Greg KH To: Leo Li Cc: Joel Stanley , Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi , Shawn Guo , dl-linux-imx , Stephen Rothwell , Ran Wang , "linux-usb@vger.kernel.org" , Linux ARM Subject: Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs Message-ID: References: <20210610034957.93376-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Jun 11, 2021 at 02:11:27AM +0000, Leo Li wrote: > > > > -----Original Message----- > > From: Joel Stanley > > Sent: Thursday, June 10, 2021 9:01 PM > > To: Fabio Estevam ; Peter Chen > > ; Arnd Bergmann ; Felipe Balbi > > ; Shawn Guo ; Leo Li > > ; dl-linux-imx ; Stephen > > Rothwell > > Cc: linux-usb@vger.kernel.org; Linux ARM > kernel@lists.infradead.org> > > Subject: Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs > > > > On Thu, 10 Jun 2021 at 03:50, Joel Stanley wrote: > > > > > > The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the > > > driver") dropped the ARCH_MXC dependency from USB_FSL_USB2, > > leaving it > > > depending solely on FSL_SOC. > > > > > > FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but > > > was removed by commit cfd074ad8600 ("ARM: imx: temporarily remove > > > CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be > > > enabled on ARM platforms. > > > > > > This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32 > > > SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: > > > > > > arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y > > > arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y > > > arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y > > > arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y > > > > > > To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the > > > ARM platforms, and with COMPILE_TEST. > > > > This didn't work out, as there's some missing clock initialisation calls that were > > removed when fsl_mxc_udc was deleted: > > > > arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function > > `fsl_udc_remove': > > fsl_udc_core.c:(.text+0xc88): undefined reference to `fsl_udc_clk_release' > > arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function > > `fsl_udc_probe': > > fsl_udc_core.c:(.text+0x1c44): undefined reference to `fsl_udc_clk_init' > > arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1dcc): undefined reference to > > `fsl_udc_clk_finalize' > > arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1fe8): undefined reference to > > `fsl_udc_clk_release' > > > > We could add them back, but it's not clear if this driver is still maintained. I'm > > looking to the NXP people for input here. > > Adding Ran Wang to the loop. I think we will maintain the driver to keep the legacy platforms working but will not add new users of this driver. Now reverted in my tree. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80585C4743D for ; Fri, 11 Jun 2021 07:24:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C3AC613B3 for ; Fri, 11 Jun 2021 07:24:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C3AC613B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8koGp31XlovS4kBsf5PurfkhiN6+WD/5PWGHbtfk8eI=; b=qFnbLv5A7L+SPR UMHsAqO1zLt2NBtJ5m1QP0OKDsiECUSeewt0hvQtuXt7+NqIl90O4VfRqOb23JxuXE3758i+Zflkv gxPb6/W3V3XSz7Qu7ybnhe5bqho4ZO6Al5LMNmcrxdFVMm3g/Vpy7AW80dejrBFz1c+yrnwsfGUNW bzPg5AbyFWjjFSBQIe85t1LJSZCiNBqUpuB/uH5iS+EBGFAFY0am/HBi6CMtEo+4bg9PwVsT1Zj9F d1dtenhmBQu/dR0vnrXAYFBZ/wQ5/KjRUAOyG2WZqGR4S2rY8DYJk0+0k22avExysUNys9nb13Gsi 0FKnKV8E/RnXbXVW1nog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrbV5-0048ZP-1W; Fri, 11 Jun 2021 07:22:43 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrbV0-0048X3-Su for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 07:22:40 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 33F9258049A; Fri, 11 Jun 2021 03:22:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 11 Jun 2021 03:22:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=5YiBwSdJLoDEOuRL8pQdjIm/ZNz uYm4POR9BQWZtsjM=; b=bavhkSfyRzKNkX8FNZRL8hkH9uvCbEVL6rnAIlbrJGL 2QAS0CcVBZSAY9PZMRUocXYoZwDTOSxVJjq3yIS8uTb3BXl/tCwCF2yMBDzDZCP3 +3l00ntbu3F51/ib8kFUeQiyvsJHMgG2kV8/oOkIOTH/Nw1A6XfNfMsxdCsfzfrG q/M7miFPzOyikxXedLIaY/HFHOfAB4w6wZqd8ed6GzrvcHN/ul36QiMzHZQOS6hG QoVHIjwTaXWKIVyWTk2MOk6PfOAAVxkZChCRwOg3niGAg0UbZlAtKDRyb+pUYWP8 62v7dlpKDIoLi1vm2vSf0D1UCocYeMTzHUJJLMWTxcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5YiBwS dJLoDEOuRL8pQdjIm/ZNzuYm4POR9BQWZtsjM=; b=WyXK0gwJM5S3YsE/kfzxsB XRwgEoBgE1AMNiLveVNxXX2uAHinlJT5ZfIf7d8Aq2+rg3M6BLFrJnXncp/1sEn7 mRtJ4HwPHYyXeJHaZbR2JpufP6TZnzJU/yvNRhrjkcLSr4hw1wKJg6iiJV5fAAK1 Q5eR6wgpd7wuPbqcmSnrfUIfmxBuE7WbKqHq+m6ud5iBKd6wAsMEjHaAP5mue5hq MdowuMrlKojI3odxyjty79W0b9mePGPNIxb2ZDbqzi5qWHSK8AFjBKhY3NOw1gd2 Y6VuaMZhAorKq+wkdbeTrN2u+X2cS+I7xPoSmCaFaNLHNaARJh7xlwz445IYkEWg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeduiedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Jun 2021 03:22:31 -0400 (EDT) Date: Fri, 11 Jun 2021 09:22:28 +0200 From: Greg KH To: Leo Li Cc: Joel Stanley , Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi , Shawn Guo , dl-linux-imx , Stephen Rothwell , Ran Wang , "linux-usb@vger.kernel.org" , Linux ARM Subject: Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs Message-ID: References: <20210610034957.93376-1-joel@jms.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_002239_032733_470B72ED X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 02:11:27AM +0000, Leo Li wrote: > > > > -----Original Message----- > > From: Joel Stanley > > Sent: Thursday, June 10, 2021 9:01 PM > > To: Fabio Estevam ; Peter Chen > > ; Arnd Bergmann ; Felipe Balbi > > ; Shawn Guo ; Leo Li > > ; dl-linux-imx ; Stephen > > Rothwell > > Cc: linux-usb@vger.kernel.org; Linux ARM > kernel@lists.infradead.org> > > Subject: Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs > > > > On Thu, 10 Jun 2021 at 03:50, Joel Stanley wrote: > > > > > > The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the > > > driver") dropped the ARCH_MXC dependency from USB_FSL_USB2, > > leaving it > > > depending solely on FSL_SOC. > > > > > > FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but > > > was removed by commit cfd074ad8600 ("ARM: imx: temporarily remove > > > CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be > > > enabled on ARM platforms. > > > > > > This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32 > > > SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: > > > > > > arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y > > > arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y > > > arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y > > > arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y > > > > > > To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the > > > ARM platforms, and with COMPILE_TEST. > > > > This didn't work out, as there's some missing clock initialisation calls that were > > removed when fsl_mxc_udc was deleted: > > > > arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function > > `fsl_udc_remove': > > fsl_udc_core.c:(.text+0xc88): undefined reference to `fsl_udc_clk_release' > > arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function > > `fsl_udc_probe': > > fsl_udc_core.c:(.text+0x1c44): undefined reference to `fsl_udc_clk_init' > > arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1dcc): undefined reference to > > `fsl_udc_clk_finalize' > > arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1fe8): undefined reference to > > `fsl_udc_clk_release' > > > > We could add them back, but it's not clear if this driver is still maintained. I'm > > looking to the NXP people for input here. > > Adding Ran Wang to the loop. I think we will maintain the driver to keep the legacy platforms working but will not add new users of this driver. Now reverted in my tree. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel