Re: [PATCHv4 5/6] misc: nxp-ezport: introduce EzPort support

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Jun 11, 2021 at 11:05:59AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 09, 2021 at 05:12:34PM +0200, Sebastian Reichel wrote:
> > Add new EzPort support code, which can be used to do
> > firmware updates of Kinetis coprocessors. The driver
> > is not usable on its own and thus not user selectable.
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> 
> Why is this a separate module if only 1 driver needs this?  Why not keep
> it together until you have a second user?
> 
> And this module is not able to be unloaded ever?  Why not?
> 
> > +int ezport_flash(struct spi_device *spi, struct gpio_desc *reset, const char *fwname)
> > +{
> > +	int ret;
> > +
> > +	ret = ezport_start_programming(spi, reset);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = ezport_firmware_load(spi, fwname);
> > +
> > +	ezport_stop_programming(spi, reset);
> > +
> > +	if (ret)
> > +		dev_err(&spi->dev, "Failed to flash firmware: %d\n", ret);
> 
> %pe perhaps instead of %d?

Oops, nope, my fault, that's not a pointer.

greg k-h