From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] Revert "drm/i915/display: Drop FIXME about turn off infoframes"
Date: Fri, 11 Jun 2021 21:19:16 +0300 [thread overview]
Message-ID: <YMOpJGGDyXPLWYF2@intel.com> (raw)
In-Reply-To: <20210610194527.84997-1-jose.souza@intel.com>
On Thu, Jun 10, 2021 at 12:45:27PM -0700, José Roberto de Souza wrote:
> Looks this FIXME is still valid as we need a way to tell LSPCON to
> stop sending infoframes, so reverting it.
>
> This reverts commit 3f409e4cd579b287a6c41d017e62c392f7997193.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 390869bd6b633..0b7fef527e202 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2810,6 +2810,7 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> conn_state);
>
> /* FIXME precompute everything properly */
> + /* FIXME how do we turn infoframes off again? */
> if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
> dig_port->set_infoframes(encoder,
> crtc_state->has_infoframe,
> --
> 2.32.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-06-11 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 19:45 [Intel-gfx] [PATCH] Revert "drm/i915/display: Drop FIXME about turn off infoframes" José Roberto de Souza
2021-06-10 20:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-06-10 23:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-11 19:20 ` Souza, Jose
2021-06-11 18:19 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMOpJGGDyXPLWYF2@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.