From: Al Viro <viro@zeniv.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, anton@enomsg.org, ccross@android.com,
tony.luck@intel.com, gmpy.liaowx@gmail.com,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mark pstore-blk as broken
Date: Mon, 14 Jun 2021 01:17:05 +0000 [thread overview]
Message-ID: <YMauEdVL/RoycCPS@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <202106081033.F59D7A4@keescook>
On Tue, Jun 08, 2021 at 10:34:29AM -0700, Kees Cook wrote:
> > diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> > index 8adabde685f1..328da35da390 100644
> > --- a/fs/pstore/Kconfig
> > +++ b/fs/pstore/Kconfig
> > @@ -173,6 +173,7 @@ config PSTORE_BLK
> > tristate "Log panic/oops to a block device"
> > depends on PSTORE
> > depends on BLOCK
> > + depends on BROKEN
> > select PSTORE_ZONE
> > default n
> > help
> > --
> > 2.30.2
> >
>
> NAK, please answer my concerns about your patches instead:
> https://lore.kernel.org/lkml/202012011149.5650B9796@keescook/
How about concerns about the code in question having gotten
into the kernel in the first place? Quality aside (that's a separate
conversation, probably for tomorrow), just what happens if that thing
is triggered by the code that happens to hold a page on block device
locked? AFAICS, __generic_file_write_iter() will cheerfully deadlock...
Kees, may I ask you where had that thing been discussed back
then? All I can see is linux-kernel, and that's "archived by", not
"discussed on"...
next prev parent reply other threads:[~2021-06-14 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 16:13 [PATCH] mark pstore-blk as broken Christoph Hellwig
2021-06-08 17:34 ` Kees Cook
2021-06-14 1:17 ` Al Viro [this message]
2021-06-14 7:07 ` Christoph Hellwig
2021-06-14 17:33 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMauEdVL/RoycCPS@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anton@enomsg.org \
--cc=axboe@kernel.dk \
--cc=ccross@android.com \
--cc=gmpy.liaowx@gmail.com \
--cc=hch@lst.de \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.