From: Lee Jones <lee.jones@linaro.org>
To: Sergey Larin <cerg2010cerg2010@mail.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: max8907: Remove IRQF_NO_AUTOEN flag
Date: Tue, 15 Jun 2021 13:19:14 +0100 [thread overview]
Message-ID: <YMiawr+12Uq4Q2n+@dell> (raw)
In-Reply-To: <20210614222420.89865-1-cerg2010cerg2010@mail.ru>
On Tue, 15 Jun 2021, Sergey Larin wrote:
> IRQF_NO_AUTOEN flag doesn't go well with IRQF_SHARED flag - the
> check in request_threaded_irq fails and exits with EINVAL.
>
> So we ignore the flag and enable it on the first IRQ request. No
> interrupt should arrive from the chip as all interrupts are masked
> by default.
>
> Signed-off-by: Sergey Larin <cerg2010cerg2010@mail.ru>
> ---
> drivers/mfd/max8907.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-06-15 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 22:24 [PATCH] mfd: max8907: Remove IRQF_NO_AUTOEN flag Sergey Larin
2021-06-15 12:19 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMiawr+12Uq4Q2n+@dell \
--to=lee.jones@linaro.org \
--cc=cerg2010cerg2010@mail.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.