From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: linux-kernel@vger.kernel.org,
Huilong Deng <denghuilong@cdjrlc.com>,
Johannes Thumshirn <jth@kernel.org>
Subject: Re: [PATCH 3/3] mcb: Remove trailing semicolon in macros
Date: Tue, 15 Jun 2021 17:48:09 +0200 [thread overview]
Message-ID: <YMjLuWRuRuMiIBjv@kroah.com> (raw)
In-Reply-To: <fe520620eeddaa2ed8c669125f9b673c89d6b5a5.1623768541.git.johannes.thumshirn@wdc.com>
On Tue, Jun 15, 2021 at 11:55:30PM +0900, Johannes Thumshirn wrote:
> From: Huilong Deng <denghuilong@cdjrlc.com>
>
> Macros should not use a trailing semicolon.
>
> Signed-off-by: Huilong Deng <denghuilong@cdjrlc.com>
> Signed-off-by: Johannes Thumshirn <jth@kernel.org>
> ---
> include/linux/mcb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mcb.h b/include/linux/mcb.h
> index 71dd10a3d928..f6efb16f9d1b 100644
> --- a/include/linux/mcb.h
> +++ b/include/linux/mcb.h
> @@ -120,7 +120,7 @@ extern int __must_check __mcb_register_driver(struct mcb_driver *drv,
> __mcb_register_driver(driver, THIS_MODULE, KBUILD_MODNAME)
> extern void mcb_unregister_driver(struct mcb_driver *driver);
> #define module_mcb_driver(__mcb_driver) \
> - module_driver(__mcb_driver, mcb_register_driver, mcb_unregister_driver);
> + module_driver(__mcb_driver, mcb_register_driver, mcb_unregister_driver)
> extern void mcb_bus_add_devices(const struct mcb_bus *bus);
> extern int mcb_device_register(struct mcb_bus *bus, struct mcb_device *dev);
> extern struct mcb_bus *mcb_alloc_bus(struct device *carrier);
> --
> 2.31.1
>
I've applied this one, feel free to resend the first 2 as emails.
thanks,
greg k-h
prev parent reply other threads:[~2021-06-15 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 14:55 [PATCH 0/3] mcb changes for 5.14 Johannes Thumshirn
2021-06-15 14:55 ` [PATCH 1/3] mcb: Use DEFINE_RES_MEM() to simplify code Johannes Thumshirn
2021-06-15 15:42 ` Greg Kroah-Hartman
2021-06-16 1:31 ` Leizhen (ThunderTown)
2021-06-16 6:41 ` Greg Kroah-Hartman
2021-06-15 14:55 ` [PATCH 2/3] mcb: fix error handling in mcb_alloc_bus() Johannes Thumshirn
2021-06-15 15:41 ` Greg Kroah-Hartman
2021-06-15 15:44 ` Johannes Thumshirn
2021-06-15 14:55 ` [PATCH 3/3] mcb: Remove trailing semicolon in macros Johannes Thumshirn
2021-06-15 15:48 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMjLuWRuRuMiIBjv@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=denghuilong@cdjrlc.com \
--cc=johannes.thumshirn@wdc.com \
--cc=jth@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.