From: Phillip Potter <phil@philpotter.co.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Larry.Finger@lwfinger.net, dan.carpenter@oracle.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 00/28] staging: rtl8188eu: remove DBG_88E callers and macro
Date: Tue, 15 Jun 2021 22:05:54 +0100 [thread overview]
Message-ID: <YMkWMsE/m99cM47/@KernelVM> (raw)
In-Reply-To: <YMiVtgVTGQSb+iC2@kroah.com>
On Tue, Jun 15, 2021 at 01:57:42PM +0200, Greg KH wrote:
> On Tue, Jun 15, 2021 at 01:14:39AM +0100, Phillip Potter wrote:
> > This patch series removes DBG_88E calls from all places in the driver,
> > and then removes the DBG_88E macro definition itself. It also takes two
> > prior patches where I convered DBG_88E calls into netdev_dbg calls, and
> > removes these calls too.
> >
> > It cleans up subsuently unused local variables along the way, removes an
> > unused static function too, and also contains a reissue of my previous
> > patch to remove core/rtw_debug.c which is entirely unused by the driver
> > and thus is dead code.
> >
> > Phillip Potter (28):
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_efuse.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_xmit.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_mlme_ext.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_wlan_util.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_ap.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_pwrctrl.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_ieee80211.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_security.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_ioctl_set.c
> > staging: rtl8188eu: remove all DBG_88E calls from core/rtw_mlme.c
> > staging: rtl8188eu: remove all DBG_88E calls from os_dep/ioctl_linux.c
> > staging: rtl8188eu: remove all DBG_88E calls from os_dep/usb_intf.c
> > staging: rtl8188eu: remove all DBG_88E calls from os_dep/os_intfs.c
> > staging: rtl8188eu: remove all DBG_88E calls from os_dep/mlme_linux.c
> > staging: rtl8188eu: remove all DBG_88E calls from os_dep/xmit_linux.c
> > staging: rtl8188eu: remove all DBG_88E calls from os_dep/rtw_android.c
> > staging: rtl8188eu: remove all DBG_88E calls from hal/hal_intf.c
> > staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188e_cmd.c
> > staging: rtl8188eu: remove all DBG_88E calls from hal/pwrseqcmd.c
> > staging: rtl8188eu: remove all DBG_88E calls from
> > hal/rtl8188e_hal_init.c
> > staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188e_xmit.c
> > staging: rtl8188eu: remove all DBG_88E calls from hal/usb_halinit.c
> > staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188eu_recv.c
> > staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188eu_xmit.c
> > staging: rtl8188eu: remove converted netdev_dbg calls from
> > core/rtw_recv.c
> > staging: rtl8188eu: remove converted netdev_dbg calls from
> > core/rtw_sta_mgt.c
> > staging: rtl8188eu: remove core/rtw_debug.c
> > staging: rtl8188eu: remove DBG_88E macro definition
> >
> > drivers/staging/rtl8188eu/Makefile | 1 -
> > drivers/staging/rtl8188eu/core/rtw_ap.c | 78 +-----
> > drivers/staging/rtl8188eu/core/rtw_debug.c | 187 -------------
> > drivers/staging/rtl8188eu/core/rtw_efuse.c | 15 +-
> > .../staging/rtl8188eu/core/rtw_ieee80211.c | 38 +--
> > .../staging/rtl8188eu/core/rtw_ioctl_set.c | 8 -
> > drivers/staging/rtl8188eu/core/rtw_mlme.c | 54 +---
> > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 262 ++----------------
> > drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 40 +--
> > drivers/staging/rtl8188eu/core/rtw_recv.c | 66 +----
> > drivers/staging/rtl8188eu/core/rtw_security.c | 2 -
> > drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 9 -
> > .../staging/rtl8188eu/core/rtw_wlan_util.c | 80 ++----
> > drivers/staging/rtl8188eu/core/rtw_xmit.c | 40 +--
> > drivers/staging/rtl8188eu/hal/hal_intf.c | 3 -
> > drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 4 +-
> > drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 42 +--
> > .../staging/rtl8188eu/hal/rtl8188e_hal_init.c | 45 +--
> > drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c | 15 -
> > .../staging/rtl8188eu/hal/rtl8188eu_recv.c | 8 -
> > .../staging/rtl8188eu/hal/rtl8188eu_xmit.c | 5 -
> > drivers/staging/rtl8188eu/hal/usb_halinit.c | 51 +---
> > drivers/staging/rtl8188eu/include/rtw_debug.h | 31 ---
> > .../staging/rtl8188eu/os_dep/ioctl_linux.c | 144 +---------
> > drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 4 -
> > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 26 --
> > .../staging/rtl8188eu/os_dep/rtw_android.c | 15 +-
> > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 -
> > drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 8 +-
> > 29 files changed, 86 insertions(+), 1196 deletions(-)
> > delete mode 100644 drivers/staging/rtl8188eu/core/rtw_debug.c
>
> Deleting that many lines of code is always nice, thanks for doing this,
> now all applied.
>
> greg k-h
Dear Greg,
Thanks for taking the patches, happy to help.
Regards,
Phil
next prev parent reply other threads:[~2021-06-15 21:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 0:14 [PATCH 00/28] staging: rtl8188eu: remove DBG_88E callers and macro Phillip Potter
2021-06-15 0:14 ` [PATCH 01/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_efuse.c Phillip Potter
2021-06-15 0:14 ` [PATCH 02/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_xmit.c Phillip Potter
2021-06-15 0:14 ` [PATCH 03/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_mlme_ext.c Phillip Potter
2021-06-15 10:32 ` Dan Carpenter
2021-06-15 21:15 ` Phillip Potter
2021-06-15 0:14 ` [PATCH 04/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_wlan_util.c Phillip Potter
2021-06-15 0:14 ` [PATCH 05/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_ap.c Phillip Potter
2021-06-15 0:14 ` [PATCH 06/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_pwrctrl.c Phillip Potter
2021-06-15 0:14 ` [PATCH 07/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_ieee80211.c Phillip Potter
2021-06-15 0:14 ` [PATCH 08/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_security.c Phillip Potter
2021-06-15 0:14 ` [PATCH 09/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_ioctl_set.c Phillip Potter
2021-06-15 0:14 ` [PATCH 10/28] staging: rtl8188eu: remove all DBG_88E calls from core/rtw_mlme.c Phillip Potter
2021-06-15 0:14 ` [PATCH 11/28] staging: rtl8188eu: remove all DBG_88E calls from os_dep/ioctl_linux.c Phillip Potter
2021-06-15 0:14 ` [PATCH 12/28] staging: rtl8188eu: remove all DBG_88E calls from os_dep/usb_intf.c Phillip Potter
2021-06-15 0:14 ` [PATCH 13/28] staging: rtl8188eu: remove all DBG_88E calls from os_dep/os_intfs.c Phillip Potter
2021-06-15 0:14 ` [PATCH 14/28] staging: rtl8188eu: remove all DBG_88E calls from os_dep/mlme_linux.c Phillip Potter
2021-06-15 0:14 ` [PATCH 15/28] staging: rtl8188eu: remove all DBG_88E calls from os_dep/xmit_linux.c Phillip Potter
2021-06-15 0:14 ` [PATCH 16/28] staging: rtl8188eu: remove all DBG_88E calls from os_dep/rtw_android.c Phillip Potter
2021-06-15 0:14 ` [PATCH 17/28] staging: rtl8188eu: remove all DBG_88E calls from hal/hal_intf.c Phillip Potter
2021-06-15 0:14 ` [PATCH 18/28] staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188e_cmd.c Phillip Potter
2021-06-15 0:14 ` [PATCH 19/28] staging: rtl8188eu: remove all DBG_88E calls from hal/pwrseqcmd.c Phillip Potter
2021-06-15 0:14 ` [PATCH 20/28] staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188e_hal_init.c Phillip Potter
2021-06-15 0:15 ` [PATCH 21/28] staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188e_xmit.c Phillip Potter
2021-06-15 0:15 ` [PATCH 22/28] staging: rtl8188eu: remove all DBG_88E calls from hal/usb_halinit.c Phillip Potter
2021-06-15 12:41 ` Dan Carpenter
2021-06-15 21:08 ` Phillip Potter
2021-06-15 0:15 ` [PATCH 23/28] staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188eu_recv.c Phillip Potter
2021-06-15 0:15 ` [PATCH 24/28] staging: rtl8188eu: remove all DBG_88E calls from hal/rtl8188eu_xmit.c Phillip Potter
2021-06-15 0:15 ` [PATCH 25/28] staging: rtl8188eu: remove converted netdev_dbg calls from core/rtw_recv.c Phillip Potter
2021-06-15 0:15 ` [PATCH 26/28] staging: rtl8188eu: remove converted netdev_dbg calls from core/rtw_sta_mgt.c Phillip Potter
2021-06-15 0:15 ` [PATCH 27/28] staging: rtl8188eu: remove core/rtw_debug.c Phillip Potter
2021-06-15 0:15 ` [PATCH 28/28] staging: rtl8188eu: remove DBG_88E macro definition Phillip Potter
2021-06-15 11:57 ` [PATCH 00/28] staging: rtl8188eu: remove DBG_88E callers and macro Greg KH
2021-06-15 21:05 ` Phillip Potter [this message]
2021-06-15 12:51 ` Dan Carpenter
2021-06-15 21:10 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMkWMsE/m99cM47/@KernelVM \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.