From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Nikolay Borisov <nborisov@suse.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 3/4] fs: add a filemap_fdatawrite_wbc helper
Date: Wed, 16 Jun 2021 05:41:44 +0100 [thread overview]
Message-ID: <YMmBCL23eCLnROJx@infradead.org> (raw)
In-Reply-To: <8c1d5edb-8149-f0e3-6170-2b25fdaa4e9f@toxicpanda.com>
On Tue, Jun 15, 2021 at 09:37:33AM -0400, Josef Bacik wrote:
> Yeah I'd like to clean this up at some point, but that's outside the scope
> of this patch. I want to get a helper in without needing to run it by
> everybody, we can take up cleaning this up at a later point with input from
> everybody else. Thanks,
But you _do_ need to run a new core writeback function past "everybody".
Just posting it on the btrfs list like for this series is definitely
not enough.
next prev parent reply other threads:[~2021-06-16 4:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 13:53 [PATCH 0/4] btrfs: shrink delalloc fixes Josef Bacik
2021-06-11 13:53 ` [PATCH 1/4] btrfs: wait on async extents when flushing delalloc Josef Bacik
2021-06-14 10:05 ` Nikolay Borisov
2021-06-14 18:30 ` Josef Bacik
2021-06-11 13:53 ` [PATCH 2/4] btrfs: wake up async_delalloc_pages waiters after submit Josef Bacik
2021-06-14 10:20 ` Nikolay Borisov
2021-06-11 13:53 ` [PATCH 3/4] fs: add a filemap_fdatawrite_wbc helper Josef Bacik
2021-06-14 10:16 ` Nikolay Borisov
2021-06-15 13:37 ` Josef Bacik
2021-06-16 4:41 ` Christoph Hellwig [this message]
2021-06-11 13:54 ` [PATCH 4/4] btrfs: use the filemap_fdatawrite_wbc helper for delalloc shrinking Josef Bacik
2021-06-14 10:57 ` Nikolay Borisov
2021-06-14 11:13 ` [PATCH 0/4] btrfs: shrink delalloc fixes Johannes Thumshirn
2021-06-14 18:38 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMmBCL23eCLnROJx@infradead.org \
--to=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.