From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1315C48BE8 for ; Wed, 16 Jun 2021 05:58:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9533B613BF for ; Wed, 16 Jun 2021 05:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbhFPGA6 (ORCPT ); Wed, 16 Jun 2021 02:00:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:57486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbhFPGA5 (ORCPT ); Wed, 16 Jun 2021 02:00:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 750176128C; Wed, 16 Jun 2021 05:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623823132; bh=mbCodwMIm1uO6V8GxochPay+jWIcegWFL544VUVwHXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M5vdOsIe2Zer92PkoDT5IunwubV5UQ1Vs7rNcq2Ea3wSGn7LJIEZLsHqaSeh7Q2wh UYg+Pvtp6gWzOE79brNsTv5CW5vKJV7rMKwVIl6VoHMMs12qrEdR6Sr0L172tju/Fd pPcZ2MXA+slC0xJ12ww6k0enzlONfls4e+4MJJWY= Date: Wed, 16 Jun 2021 07:58:48 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 1/4] remoteproc: core: Move cdev add before device add Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-2-git-send-email-sidgup@codeaurora.org> <0a196786-f624-d9bb-8ef9-55c04ed57497@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a196786-f624-d9bb-8ef9-55c04ed57497@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jun 15, 2021 at 12:03:26PM -0700, Siddharth Gupta wrote: > > On 6/14/2021 9:56 PM, Greg KH wrote: > > On Mon, Jun 14, 2021 at 07:21:08PM -0700, Siddharth Gupta wrote: > > > When cdev_add is called after device_add has been called there is no > > > way for the userspace to know about the addition of a cdev as cdev_add > > > itself doesn't trigger a uevent notification, or for the kernel to > > > know about the change to devt. This results in two problems: > > > - mknod is never called for the cdev and hence no cdev appears on > > > devtmpfs. > > > - sysfs links to the new cdev are not established. > > > > > > The cdev needs to be added and devt assigned before device_add() is > > > called in order for the relevant sysfs and devtmpfs entries to be > > > created and the uevent to be properly populated. > > So this means no one ever ran this code on a system that used devtmpfs? > > > > How was it ever tested? > My testing was done with toybox + Android's ueventd ramdisk. > As I mentioned in the discussion, the race became evident > recently. I will make sure to test all such changes without > systemd/ueventd in the future. It isn't an issue of systemd/ueventd, those do not control /dev on a normal system, that is what devtmpfs is for. And devtmpfs nodes are only created if you create a struct device somewhere with a proper major/minor, which you were not doing here, so you must have had a static /dev on your test systems, right? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F09C48BE5 for ; Wed, 16 Jun 2021 06:00:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB0366128C for ; Wed, 16 Jun 2021 06:00:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB0366128C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mmejUeQ8vCpdSBzfdG1lOko/x2a36zFbaJKLpys6aUE=; b=GJVafLfH0qf1Ev A0iO7Ob2iEDelx8hFI4fbgMyeEb4ylYn2o+dzdCLMK2LVrP74/J/K4PcQvQUMCEpaFUJ63ZhxdhOY Xa92AQf0vIDtVMencxYk7sjR+XVylq8RRDyrVfpXWx5s2q93NmyE9frKroH5Qxin+/OijIRKBXHNd tnSdmOXhGdfqBhhzo8lRfJ+HHfgn0JijBxGlgXuUBuDR/CRT3ZfSrCXi62Rny0ftRwLlLB0UO6D74 YdCsXwX5y1apU8m5zW8/FlkwDeV0NPVe9v8N6KMC3ywSr6yK1+dqEGVXJQP0SQP1kpa+YoSldOdfJ 17C2LY1dZ0mLzgCMnNxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltOZl-004y8A-0p; Wed, 16 Jun 2021 05:58:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltOZg-004y72-Tu for linux-arm-kernel@lists.infradead.org; Wed, 16 Jun 2021 05:58:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 750176128C; Wed, 16 Jun 2021 05:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623823132; bh=mbCodwMIm1uO6V8GxochPay+jWIcegWFL544VUVwHXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M5vdOsIe2Zer92PkoDT5IunwubV5UQ1Vs7rNcq2Ea3wSGn7LJIEZLsHqaSeh7Q2wh UYg+Pvtp6gWzOE79brNsTv5CW5vKJV7rMKwVIl6VoHMMs12qrEdR6Sr0L172tju/Fd pPcZ2MXA+slC0xJ12ww6k0enzlONfls4e+4MJJWY= Date: Wed, 16 Jun 2021 07:58:48 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 1/4] remoteproc: core: Move cdev add before device add Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-2-git-send-email-sidgup@codeaurora.org> <0a196786-f624-d9bb-8ef9-55c04ed57497@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0a196786-f624-d9bb-8ef9-55c04ed57497@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_225853_024527_435FC19A X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 12:03:26PM -0700, Siddharth Gupta wrote: > > On 6/14/2021 9:56 PM, Greg KH wrote: > > On Mon, Jun 14, 2021 at 07:21:08PM -0700, Siddharth Gupta wrote: > > > When cdev_add is called after device_add has been called there is no > > > way for the userspace to know about the addition of a cdev as cdev_add > > > itself doesn't trigger a uevent notification, or for the kernel to > > > know about the change to devt. This results in two problems: > > > - mknod is never called for the cdev and hence no cdev appears on > > > devtmpfs. > > > - sysfs links to the new cdev are not established. > > > > > > The cdev needs to be added and devt assigned before device_add() is > > > called in order for the relevant sysfs and devtmpfs entries to be > > > created and the uevent to be properly populated. > > So this means no one ever ran this code on a system that used devtmpfs? > > > > How was it ever tested? > My testing was done with toybox + Android's ueventd ramdisk. > As I mentioned in the discussion, the race became evident > recently. I will make sure to test all such changes without > systemd/ueventd in the future. It isn't an issue of systemd/ueventd, those do not control /dev on a normal system, that is what devtmpfs is for. And devtmpfs nodes are only created if you create a struct device somewhere with a proper major/minor, which you were not doing here, so you must have had a static /dev on your test systems, right? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel