From: Andrew Lunn <andrew@lunn.ch>
To: Guangbin Huang <huangguangbin2@huawei.com>
Cc: davem@davemloft.net, kuba@kernel.org, xie.he.0141@gmail.com,
ms@dev.tdt.de, willemb@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, lipeng321@huawei.com
Subject: Re: [PATCH net-next 7/8] net: hdlc_ppp: remove redundant spaces
Date: Wed, 16 Jun 2021 18:23:14 +0200 [thread overview]
Message-ID: <YMolcod68MZqfNFL@lunn.ch> (raw)
In-Reply-To: <1623836037-26812-8-git-send-email-huangguangbin2@huawei.com>
On Wed, Jun 16, 2021 at 05:33:56PM +0800, Guangbin Huang wrote:
> From: Peng Li <lipeng321@huawei.com>
>
> According to the chackpatch.pl,
> no spaces is necessary at the start of a line.
>
> Signed-off-by: Peng Li <lipeng321@huawei.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
> ---
> drivers/net/wan/hdlc_ppp.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
> index 7b7c02d..53c668e 100644
> --- a/drivers/net/wan/hdlc_ppp.c
> +++ b/drivers/net/wan/hdlc_ppp.c
> @@ -34,8 +34,8 @@
>
> enum {IDX_LCP = 0, IDX_IPCP, IDX_IPV6CP, IDX_COUNT};
> enum {CP_CONF_REQ = 1, CP_CONF_ACK, CP_CONF_NAK, CP_CONF_REJ, CP_TERM_REQ,
> - CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
> - LCP_DISC_REQ, CP_CODES};
> + CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
> + LCP_DISC_REQ, CP_CODES};
Do you think this looks better or worse after the change?
Andrew
next prev parent reply other threads:[~2021-06-16 16:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:33 [PATCH net-next 0/8] net: hdlc_ppp: clean up some code style issues Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 1/8] net: hdlc_ppp: remove redundant blank lines Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 2/8] net: hdlc_ppp: add blank line after declarations Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 3/8] net: hdlc_ppp: fix the code style issue about "foo* bar" Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 4/8] net: hdlc_ppp: move out assignment in if condition Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue Guangbin Huang
2021-06-16 16:20 ` Andrew Lunn
2021-06-17 1:00 ` lipeng (Y)
2021-06-16 9:33 ` [PATCH net-next 6/8] net: hdlc_ppp: remove unnecessary out of memory message Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 7/8] net: hdlc_ppp: remove redundant spaces Guangbin Huang
2021-06-16 16:23 ` Andrew Lunn [this message]
2021-06-17 1:05 ` lipeng (Y)
2021-06-16 9:33 ` [PATCH net-next 8/8] net: hdlc_ppp: add required space Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMolcod68MZqfNFL@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.