From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1762C2B9F4 for ; Thu, 17 Jun 2021 13:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AA6661351 for ; Thu, 17 Jun 2021 13:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232149AbhFQNCt (ORCPT ); Thu, 17 Jun 2021 09:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232144AbhFQNCs (ORCPT ); Thu, 17 Jun 2021 09:02:48 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15516C06175F for ; Thu, 17 Jun 2021 06:00:40 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id a11so6687015wrt.13 for ; Thu, 17 Jun 2021 06:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=q6sEldOshJn0d8J/CoZlCtjXPMRrbnfqOQaf1QjIP4o=; b=u7WuXhGP3XfHgRBI9wOyYE6oh5SjfGbupOvlA6B8PawY7jcrsOCHkod2QqJj6DP+vY Mi7p1t4vmOAZVX3Qst7B3dBlDOd6L2j64ak+7EDVKnfyvlD7fZnxRi+H1iqdp2AEh7UV lu7WJcYQWVjAXny2ZKZqiX9XRWc9MqwPyiUOV6XJng7lSQGfHmZmkjefOaqt+bYxjejY it3nZklRrdZ7rIwFsCMGjDoS4/gp1fZOODk41OusP/DM83TaE78hmg7GhT/Jj25pgMMc YahR9dcMGe10X7z76xX0x2s3umGI3LQXkjHGhwGR5exb5UmyvkaNLDOTpX6vJKyJ+jeX n1TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=q6sEldOshJn0d8J/CoZlCtjXPMRrbnfqOQaf1QjIP4o=; b=iWbIPkox9DZTACXnVjKJCfHqXYuRJs8ndVWGQDDITqt+KO5C+dFabOpAS1tn7/J6Sl +BtsKQrYhqPWkUALSZJ1IckCrzbikpHnk4nYNpm82OxCizYaTDaxigQY1IJThKQqImcy LJx8oSa+u7xVQiG3lTsv7NmczTtIUod2EM+fcLifI4xeHFB5wQc2PA4t20Sy7RRqpUIC cRlr4sf7BqRen/j52uTvmw9WjAjQlxEgO+wM8F/tyIRFUTKcQq/XRqOrRt2UnzpQ7F5w KvxoZqqMl+UW/axhVasgFKkTh8kCnrqFzHkTuCOkfDPgz23KixfIourgoKjDLQWLOeRQ ycYw== X-Gm-Message-State: AOAM531EUvZ70BjLPgLPE5a7KVJIPM4VDwWsu2KKdMjQWlFfFDEInrTJ aTMGk1X2cBV5EKpyyhbf1UdSkw== X-Google-Smtp-Source: ABdhPJyJM8Z6uwWVeoMPriMzHYvSdXrYItDTn/79jdUDu1m/exBSih1FGpZObVVKSjX2lWkkCYnwdA== X-Received: by 2002:a05:6000:2ce:: with SMTP id o14mr5711931wry.145.1623934838323; Thu, 17 Jun 2021 06:00:38 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id l3sm4504674wmh.2.2021.06.17.06.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 06:00:37 -0700 (PDT) Date: Thu, 17 Jun 2021 15:00:34 +0200 From: LABBE Corentin To: YueHaibing Cc: ulli.kroll@googlemail.com, linus.walleij@linaro.org, herbert@gondor.apana.org.au, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] crypto: sl3516 - Fix build warning without CONFIG_PM Message-ID: References: <20210617035129.4948-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210617035129.4948-1-yuehaibing@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Le Thu, Jun 17, 2021 at 11:51:29AM +0800, YueHaibing a écrit : > drivers/crypto/gemini/sl3516-ce-core.c:345:12: > warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function] > static int sl3516_ce_pm_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~ > > Use #ifdef macro to guard this. > > Signed-off-by: YueHaibing > --- > drivers/crypto/gemini/sl3516-ce-core.c | 2 ++ > 1 file changed, 2 insertions(+) > Hello Thanks for the report, but I am sorry and need to NAK this patch. The driver needs PM, without it, clock and resets are never set. The correct fix is to add "depends on PM". Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BC4C2B9F4 for ; Thu, 17 Jun 2021 13:02:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B2E5613A9 for ; Thu, 17 Jun 2021 13:02:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B2E5613A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LqjPHPZzznDn6QAHAFO1fmxqt8LQlzcHQ1YyJngF3/Q=; b=llKoyJilU8nXSA omEL9QADww38bzdvMXUcnMBg9xdjvH1kSI/xJ2MBYj+PhdZ+cuAhwmGchkWEnXEZea5iTrnuEgsDw xSVfZHpNvmmwDCyUMzok/tpgcbm5Qbfah+Pz2WhnJQtsF4DbE9qpyQ5qKSU/HGWzK0PTlVH8HgL/4 94p3+oj7qWVjwfyww2pVhTbPpyfV/lVVabY7IKASRnKSiNolIZnEGDor9ElO0FZmCqQwl18+Jdj5W zxbkr5bw4ohYSLZ/uKxVIA3HgsHbZpsqqVMTXESE1EXIQULv/h3LatKpJKxwLGg3vGi22ax35cg/C mGwZVgDfIraaraC8YYMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltrdV-00AN0j-80; Thu, 17 Jun 2021 13:00:45 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltrdQ-00AMzV-9w for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 13:00:42 +0000 Received: by mail-wr1-x42a.google.com with SMTP id o3so6701541wri.8 for ; Thu, 17 Jun 2021 06:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=q6sEldOshJn0d8J/CoZlCtjXPMRrbnfqOQaf1QjIP4o=; b=u7WuXhGP3XfHgRBI9wOyYE6oh5SjfGbupOvlA6B8PawY7jcrsOCHkod2QqJj6DP+vY Mi7p1t4vmOAZVX3Qst7B3dBlDOd6L2j64ak+7EDVKnfyvlD7fZnxRi+H1iqdp2AEh7UV lu7WJcYQWVjAXny2ZKZqiX9XRWc9MqwPyiUOV6XJng7lSQGfHmZmkjefOaqt+bYxjejY it3nZklRrdZ7rIwFsCMGjDoS4/gp1fZOODk41OusP/DM83TaE78hmg7GhT/Jj25pgMMc YahR9dcMGe10X7z76xX0x2s3umGI3LQXkjHGhwGR5exb5UmyvkaNLDOTpX6vJKyJ+jeX n1TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=q6sEldOshJn0d8J/CoZlCtjXPMRrbnfqOQaf1QjIP4o=; b=aliUnfXNBVM4TA+CiFrw6jYqAokHx9nJA+UrplAcVF3UN9fAK4OrfkQBxWZR0pVjn0 n+jJ1LQKlpsFEN3+BBnhcln0WCQ2x0IQnKPQ4WZ3G4yE99whcv4DbxYPLFpvuQ06VqyO FDOk6oH93EGvr9rRxhQhIGc3uhU7e7cUF+SQskO81s7YcP2YrFdnVNEqTmwVIpn6KkAl C9Y+SpoPJiMmdrrVwNqW41mTf0xr4smHlLyWZdCjZlYlDV1gJ9fFc42BKr0GSWxiSA7/ 3GCE0xu7d93CAdw1mOz6byBVtGhq2hTMk2i+bKoAeMdCD1/Q83SjdLxIZ+KmEPHKOU9a CxXQ== X-Gm-Message-State: AOAM533p0pL91p9vPkeEPjqhwfvCZ5Imjo0n3C9l0eXqot4KDQ1ySXSf tWt09JOqO/oNfBCSUWaR74E7BA== X-Google-Smtp-Source: ABdhPJyJM8Z6uwWVeoMPriMzHYvSdXrYItDTn/79jdUDu1m/exBSih1FGpZObVVKSjX2lWkkCYnwdA== X-Received: by 2002:a05:6000:2ce:: with SMTP id o14mr5711931wry.145.1623934838323; Thu, 17 Jun 2021 06:00:38 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id l3sm4504674wmh.2.2021.06.17.06.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 06:00:37 -0700 (PDT) Date: Thu, 17 Jun 2021 15:00:34 +0200 From: LABBE Corentin To: YueHaibing Cc: ulli.kroll@googlemail.com, linus.walleij@linaro.org, herbert@gondor.apana.org.au, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] crypto: sl3516 - Fix build warning without CONFIG_PM Message-ID: References: <20210617035129.4948-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210617035129.4948-1-yuehaibing@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_060040_448028_5C271096 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgVGh1LCBKdW4gMTcsIDIwMjEgYXQgMTE6NTE6MjlBTSArMDgwMCwgWXVlSGFpYmluZyBhIMOp Y3JpdCA6Cj4gZHJpdmVycy9jcnlwdG8vZ2VtaW5pL3NsMzUxNi1jZS1jb3JlLmM6MzQ1OjEyOgo+ ICB3YXJuaW5nOiDigJhzbDM1MTZfY2VfcG1fcmVzdW1l4oCZIGRlZmluZWQgYnV0IG5vdCB1c2Vk IFstV3VudXNlZC1mdW5jdGlvbl0KPiAgc3RhdGljIGludCBzbDM1MTZfY2VfcG1fcmVzdW1lKHN0 cnVjdCBkZXZpY2UgKmRldikKPiAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+Cj4gCj4g VXNlICNpZmRlZiBtYWNybyB0byBndWFyZCB0aGlzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFl1ZUhh aWJpbmcgPHl1ZWhhaWJpbmdAaHVhd2VpLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9jcnlwdG8vZ2Vt aW5pL3NsMzUxNi1jZS1jb3JlLmMgfCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKykKPiAKCkhlbGxvCgpUaGFua3MgZm9yIHRoZSByZXBvcnQsIGJ1dCBJIGFtIHNvcnJ5IGFu ZCBuZWVkIHRvIE5BSyB0aGlzIHBhdGNoLgoKVGhlIGRyaXZlciBuZWVkcyBQTSwgd2l0aG91dCBp dCwgY2xvY2sgYW5kIHJlc2V0cyBhcmUgbmV2ZXIgc2V0LgpUaGUgY29ycmVjdCBmaXggaXMgdG8g YWRkICJkZXBlbmRzIG9uIFBNIi4KClJlZ2FyZHMKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK