From: "Theodore Ts'o" <tytso@mit.edu>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, adilger.kernel@dilger.ca
Subject: Re: [PATCH] ext4: return error code when ext4_fill_flex_info() fails
Date: Thu, 17 Jun 2021 10:52:22 -0400 [thread overview]
Message-ID: <YMthpl31g7j+fB6m@mit.edu> (raw)
In-Reply-To: <20210510111051.55650-1-yangyingliang@huawei.com>
On Mon, May 10, 2021 at 07:10:51PM +0800, Yang Yingliang wrote:
> After commit c89128a00838 ("ext4: handle errors on ext4_commit_super"), 'ret' may
> be set to 0 before calling ext4_fill_flex_info(), if ext4_fill_flex_info() fails
> ext4_mount() doesn't return error code, it makes 'root' is null which causes
> crash in legacy_get_tree().
>
> Fixes: c89128a00838 ("ext4: handle errors on ext4_commit_super")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Cc: <stable@vger.kernel.org> # v4.18+
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2021-06-17 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 11:10 [PATCH] ext4: return error code when ext4_fill_flex_info() fails Yang Yingliang
2021-06-17 14:52 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMthpl31g7j+fB6m@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.