From: Boqun Feng <boqun.feng@gmail.com>
To: Xiongwei Song <sxwjean@me.com>
Cc: peterz@infradead.org, mingo@redhat.com, will@kernel.org,
longman@redhat.com, linux-kernel@vger.kernel.org,
Xiongwei Song <sxwjean@gmail.com>
Subject: Re: [PATCH] locking/lockdep: correct the description error for check_redundant()
Date: Thu, 17 Jun 2021 23:17:19 +0800 [thread overview]
Message-ID: <YMtnf4lOEiF++32w@boqun-archlinux> (raw)
In-Reply-To: <20210617150523.454965-1-sxwjean@me.com>
On Thu, Jun 17, 2021 at 11:05:23PM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> If there is no matched result, check_redundant() will return BFS_RNOMATCH.
>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Good catch!
Nit: you may want to capitalize the first letter after subsystem tag in
the patch title, like:
"locking/lockdep: Correct ..."
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> ---
> kernel/locking/lockdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index cfe0f4374594..1f126ca7fbd7 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
> * <target> or not. If it can, <src> -> <target> dependency is already
> * in the graph.
> *
> - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
> * any error appears in the bfs search.
> */
> static noinline enum bfs_result
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-06-17 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 15:05 [PATCH] locking/lockdep: correct the description error for check_redundant() Xiongwei Song
2021-06-17 15:17 ` Boqun Feng [this message]
2021-06-18 1:50 ` Xiongwei Song
-- strict thread matches above, loose matches on Subject: below --
2021-06-18 13:02 [PATCH] locking/lockdep: Correct " Xiongwei Song
2021-06-18 13:16 ` Xiongwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMtnf4lOEiF++32w@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.