From: Greg KH <gregkh@linuxfoundation.org>
To: Li Jun <jun.li@nxp.com>
Cc: peter.chen@kernel.org, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org, linux-imx@nxp.com,
zhipeng.wang_1@nxp.com
Subject: Re: [PATCH v2] usb: chipidea: host: fix port index underflow and UBSAN complains
Date: Fri, 18 Jun 2021 09:57:58 +0200 [thread overview]
Message-ID: <YMxSBpXrOCljlVuF@kroah.com> (raw)
In-Reply-To: <YMxPBdaTNNMf5rIg@kroah.com>
On Fri, Jun 18, 2021 at 09:45:09AM +0200, Greg KH wrote:
> On Fri, Jun 18, 2021 at 03:04:39PM +0800, Li Jun wrote:
> > If wIndex is 0 (and it often is), these calculations underflow and
> > UBSAN complains, here resolve this by not decrementing the index when
> > it is equal to 0, this copies the solution from commit 85e3990bea49
> > ("USB: EHCI: avoid undefined pointer arithmetic and placate UBSAN")
> >
> > Reported-by: zhipeng.wang <zhipeng.wang_1@nxp.com>
>
> Please use a name here that makes sense, "Zhipeng Wang"?
Specifically, the "." in the name as written originally does not make
sense, right?
next prev parent reply other threads:[~2021-06-18 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 7:04 [PATCH v2] usb: chipidea: host: fix port index underflow and UBSAN complains Li Jun
2021-06-18 7:45 ` Greg KH
2021-06-18 7:57 ` Greg KH [this message]
2021-06-18 8:40 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMxSBpXrOCljlVuF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=zhipeng.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.