From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEC7C48BDF for ; Fri, 18 Jun 2021 08:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E676112D for ; Fri, 18 Jun 2021 08:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbhFRIyF (ORCPT ); Fri, 18 Jun 2021 04:54:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbhFRIyF (ORCPT ); Fri, 18 Jun 2021 04:54:05 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C25FC061574; Fri, 18 Jun 2021 01:51:56 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED5A39E2; Fri, 18 Jun 2021 10:51:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624006314; bh=hQUo8DwHO+tQhJOPDPy0YoUUC+505MJXlaAzlDU0TRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SW73oHrQgZooWCoWzajTCIkAF8Z5FCYOY15yl4CPuvbxV0ccV3ravMF0lGHkoqp8u LESEP7FqQdFMA4/83CtrjZmjTSsXZ6aBXhbGWp5YBUv6VBZX3LGVEdzMm9/TmVFtCP ZRa0v8OVpNRfJh4FlldQQXrmkfZydHO+QiLPHduU= Date: Fri, 18 Jun 2021 11:51:30 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= , David Airlie , Daniel Vetter , Michal Simek , alexandre.torgue@foss.st.com, Collabora Kernel ML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Rob Herring , Wei Xu , Maxime Coquelin , Marek Vasut , Linux-Renesas Subject: Re: [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml Message-ID: References: <20210615131333.2272473-1-ricardo.canuelo@collabora.com> <20210615131333.2272473-4-ricardo.canuelo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, On Fri, Jun 18, 2021 at 09:55:38AM +0200, Geert Uytterhoeven wrote: > On Tue, Jun 15, 2021 at 3:15 PM Ricardo Cañuelo wrote: > > Convert the ADV7511/11w/13/33/35 DT bindings to json-schema. The > > original binding has been split into two files: adi,adv7511.yaml for > > ADV7511/11W/13 and adi,adv7533.yaml for ADV7533/35. > > > > Signed-off-by: Ricardo Cañuelo > > Reviewed-by: Rob Herring > > Reviewed-by: Laurent Pinchart > > Thanks for your patch, which is now commit cfe34bb7a770c5d8 > ("dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml") > in robh/for-next. > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml > > > +required: > > + - compatible > > + - reg > > + - ports > > + - adi,input-depth > > + - adi,input-colorspace > > + - adi,input-clock > > + - avdd-supply > > + - dvdd-supply > > + - pvdd-supply > > + - dvdd-3v-supply > > + - bgvdd-supply > > This causes lots of failures like: > > arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dt.yaml: hdmi@39: > 'avdd-supply' is a required property > > Should all supplies be required? > Looking at the driver, missing supplies are automatically replaced by > dummy regulators by the regulator framework. Generally speaking, I like DT bindings to be descriptive of the hardware, and thus require power supplies that are needed for the device to function, even if they are fixed supplies. This being said, I think there's also room to group some power supplies together in the bindings, when they are not meant by the device to be controlled separately. In this specific case, we also need to take into account that the adv7511 and adv7533 have different supplies. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57201C49361 for ; Fri, 18 Jun 2021 08:53:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DD23613B9 for ; Fri, 18 Jun 2021 08:53:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DD23613B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WKq7+38/eMsRDgHSIHxcN+YScxtiiiLgblNroU7fEUc=; b=tabH8fwyXG85jI NIVztKEyfU6JZWAQWP23xkCMqWuEoz+fVGZDlJ/A+w6TG2Dg9Bx308D+RlUOOeb9LYuzkv7dFk0pa wtVPiYhj5mKTsnwrTnkonheOZtG9wFxzKbJDrnvttAteUbgvgi0xLIUoB2Nyic7qoN0pBhkecypgX RoTyKmNcpQrMzjH146HR5nVAf8XxwhwamogsC4usRCXdNXHZAXlARI5EWLNGlRnOrdeqC0t5SYeir xaay488BRRklbFGjA5ullTgnguWvINiozN6OuWtdNOAIpS8yHPjpLA+4MMbjS61HUAMiMi/ev4yi2 Up3K6e+yc7CeYVDuT77w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1luAEM-00DN9q-Dw; Fri, 18 Jun 2021 08:52:02 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1luAEJ-00DN8e-D0 for linux-arm-kernel@lists.infradead.org; Fri, 18 Jun 2021 08:52:00 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED5A39E2; Fri, 18 Jun 2021 10:51:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624006314; bh=hQUo8DwHO+tQhJOPDPy0YoUUC+505MJXlaAzlDU0TRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SW73oHrQgZooWCoWzajTCIkAF8Z5FCYOY15yl4CPuvbxV0ccV3ravMF0lGHkoqp8u LESEP7FqQdFMA4/83CtrjZmjTSsXZ6aBXhbGWp5YBUv6VBZX3LGVEdzMm9/TmVFtCP ZRa0v8OVpNRfJh4FlldQQXrmkfZydHO+QiLPHduU= Date: Fri, 18 Jun 2021 11:51:30 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= , David Airlie , Daniel Vetter , Michal Simek , alexandre.torgue@foss.st.com, Collabora Kernel ML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Rob Herring , Wei Xu , Maxime Coquelin , Marek Vasut , Linux-Renesas Subject: Re: [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi, adv7511.txt: convert to yaml Message-ID: References: <20210615131333.2272473-1-ricardo.canuelo@collabora.com> <20210615131333.2272473-4-ricardo.canuelo@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210618_015159_631979_2BD9CE17 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgR2VlcnQsCgpPbiBGcmksIEp1biAxOCwgMjAyMSBhdCAwOTo1NTozOEFNICswMjAwLCBHZWVy dCBVeXR0ZXJob2V2ZW4gd3JvdGU6Cj4gT24gVHVlLCBKdW4gMTUsIDIwMjEgYXQgMzoxNSBQTSBS aWNhcmRvIENhw7F1ZWxvIHdyb3RlOgo+ID4gQ29udmVydCB0aGUgQURWNzUxMS8xMXcvMTMvMzMv MzUgRFQgYmluZGluZ3MgdG8ganNvbi1zY2hlbWEuIFRoZQo+ID4gb3JpZ2luYWwgYmluZGluZyBo YXMgYmVlbiBzcGxpdCBpbnRvIHR3byBmaWxlczogYWRpLGFkdjc1MTEueWFtbCBmb3IKPiA+IEFE Vjc1MTEvMTFXLzEzIGFuZCBhZGksYWR2NzUzMy55YW1sIGZvciBBRFY3NTMzLzM1Lgo+ID4KPiA+ IFNpZ25lZC1vZmYtYnk6IFJpY2FyZG8gQ2HDsXVlbG8gPHJpY2FyZG8uY2FudWVsb0Bjb2xsYWJv cmEuY29tPgo+ID4gUmV2aWV3ZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+Cj4g PiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29u Ym9hcmQuY29tPgo+IAo+IFRoYW5rcyBmb3IgeW91ciBwYXRjaCwgd2hpY2ggaXMgbm93IGNvbW1p dCBjZmUzNGJiN2E3NzBjNWQ4Cj4gKCJkdC1iaW5kaW5nczogZHJtOiBicmlkZ2U6IGFkaSxhZHY3 NTExLnR4dDogY29udmVydCB0byB5YW1sIikKPiBpbiByb2JoL2Zvci1uZXh0Lgo+IAo+ID4gLS0t IC9kZXYvbnVsbAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rp c3BsYXkvYnJpZGdlL2FkaSxhZHY3NTExLnlhbWwKPiAKPiA+ICtyZXF1aXJlZDoKPiA+ICsgIC0g Y29tcGF0aWJsZQo+ID4gKyAgLSByZWcKPiA+ICsgIC0gcG9ydHMKPiA+ICsgIC0gYWRpLGlucHV0 LWRlcHRoCj4gPiArICAtIGFkaSxpbnB1dC1jb2xvcnNwYWNlCj4gPiArICAtIGFkaSxpbnB1dC1j bG9jawo+ID4gKyAgLSBhdmRkLXN1cHBseQo+ID4gKyAgLSBkdmRkLXN1cHBseQo+ID4gKyAgLSBw dmRkLXN1cHBseQo+ID4gKyAgLSBkdmRkLTN2LXN1cHBseQo+ID4gKyAgLSBiZ3ZkZC1zdXBwbHkK PiAKPiBUaGlzIGNhdXNlcyBsb3RzIG9mIGZhaWx1cmVzIGxpa2U6Cj4gCj4gICAgIGFybS9ib290 L2R0cy9yOGE3NzQzLWl3ZzIwZC1xNy1kYmNtLWNhLmR0LnlhbWw6IGhkbWlAMzk6Cj4gJ2F2ZGQt c3VwcGx5JyBpcyBhIHJlcXVpcmVkIHByb3BlcnR5Cj4gCj4gU2hvdWxkIGFsbCBzdXBwbGllcyBi ZSByZXF1aXJlZD8KPiBMb29raW5nIGF0IHRoZSBkcml2ZXIsIG1pc3Npbmcgc3VwcGxpZXMgYXJl IGF1dG9tYXRpY2FsbHkgcmVwbGFjZWQgYnkKPiBkdW1teSByZWd1bGF0b3JzIGJ5IHRoZSByZWd1 bGF0b3IgZnJhbWV3b3JrLgoKR2VuZXJhbGx5IHNwZWFraW5nLCBJIGxpa2UgRFQgYmluZGluZ3Mg dG8gYmUgZGVzY3JpcHRpdmUgb2YgdGhlCmhhcmR3YXJlLCBhbmQgdGh1cyByZXF1aXJlIHBvd2Vy IHN1cHBsaWVzIHRoYXQgYXJlIG5lZWRlZCBmb3IgdGhlIGRldmljZQp0byBmdW5jdGlvbiwgZXZl biBpZiB0aGV5IGFyZSBmaXhlZCBzdXBwbGllcy4KClRoaXMgYmVpbmcgc2FpZCwgSSB0aGluayB0 aGVyZSdzIGFsc28gcm9vbSB0byBncm91cCBzb21lIHBvd2VyIHN1cHBsaWVzCnRvZ2V0aGVyIGlu IHRoZSBiaW5kaW5ncywgd2hlbiB0aGV5IGFyZSBub3QgbWVhbnQgYnkgdGhlIGRldmljZSB0byBi ZQpjb250cm9sbGVkIHNlcGFyYXRlbHkuIEluIHRoaXMgc3BlY2lmaWMgY2FzZSwgd2UgYWxzbyBu ZWVkIHRvIHRha2UgaW50bwphY2NvdW50IHRoYXQgdGhlIGFkdjc1MTEgYW5kIGFkdjc1MzMgaGF2 ZSBkaWZmZXJlbnQgc3VwcGxpZXMuCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK