From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A462C48BDF for ; Fri, 18 Jun 2021 16:03:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1425261004 for ; Fri, 18 Jun 2021 16:03:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1425261004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luGxl-0004jc-Qp for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 12:03:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luGuk-00016J-PY for qemu-devel@nongnu.org; Fri, 18 Jun 2021 12:00:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luGuf-0003fh-0v for qemu-devel@nongnu.org; Fri, 18 Jun 2021 12:00:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624032008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ST6OlA7udOYqMEd6UPgqsDs114jqHzobLTHi8cMB2WE=; b=NjTyAGiN9cIiMADOEU573jPDgVj0efW3XMkrmBjWYNrGlcttnIpTrMvyHzXmnQGdhCeeWX kVrr35ybd3758dGVMc4K5Bd2IfUpT+t7iaMs6leAtF0Hbyec7QEy0vGD7JQkYhTsz8rlnp pFISsRLoGOZEUBQ7QRQtt67seRH1hJI= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-404-MDnB4F-OOjCt55qyHidftA-1; Fri, 18 Jun 2021 12:00:04 -0400 X-MC-Unique: MDnB4F-OOjCt55qyHidftA-1 Received: by mail-qt1-f198.google.com with SMTP id 61-20020aed21430000b029024e7e455d67so7709005qtc.16 for ; Fri, 18 Jun 2021 09:00:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ST6OlA7udOYqMEd6UPgqsDs114jqHzobLTHi8cMB2WE=; b=D4Apg8e3Fx5rVtzqNVtIf1WYxcYciP4kC9ICjxs8ecfJWnNvyFr4lSiremd8IRaCMF 17ikyksS7eyfXMJ02g4Avpy8iCAltaswsp0kEk2CinLYAdKKV71EN4xNeHWT8VtmUZ3a 6IbbWnPYYTwPMXLgaexITWgUQlZvRwMc8M3zazFWzAJZVxFGQkhYzvtZkfqsaQpODnho u73q3w8r+lBRx1KXBbsoOqoFZvnYXNMPzM8xe5C/F0W2KizwFI5W2voKbdNxCJvXBxwk EOzZIS0VngkKGdTO86tQeIjwIzsCA8o+MuOpaYzpXsoye09C7UnADboQvXrdBHsHoN5S DrlQ== X-Gm-Message-State: AOAM5318HU6a0hjhaS+jVazPTBDOg8yepkKOwm5DcpDqjQ5IcTBN+t27 oXBQFyt+OxMgLlR6HWqPajcQH3+351+rxv+1I8xUxlMBgG/+ivNJMAkqNhRmPaKxtb3wC9VzI16 +vp0kBkEWThVmi78= X-Received: by 2002:a37:5c87:: with SMTP id q129mr9922826qkb.137.1624032004440; Fri, 18 Jun 2021 09:00:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAdiTl5assHuFpMrCQREfVqTIUHCtVXJf/SLNmloGmEAyhSdUg10RL9Gt0yWwaek5CFeGqsw== X-Received: by 2002:a37:5c87:: with SMTP id q129mr9922811qkb.137.1624032004199; Fri, 18 Jun 2021 09:00:04 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id r6sm1028554qtx.89.2021.06.18.09.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 09:00:03 -0700 (PDT) Date: Fri, 18 Jun 2021 12:00:02 -0400 From: Peter Xu To: huangy81@chinatelecom.cn Subject: Re: [PATCH v8 0/6] support dirtyrate at the granualrity of vcpu Message-ID: References: MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.194, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Juan Quintela , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Chuan Zheng , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 18, 2021 at 11:32:01PM +0800, huangy81@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > v8 I have one last comment in patch 2, the rest looks good to me, thanks. I think the next step can be that we add another command to configure dirty rate limit for each of the vcpu. It can be the 3rd bit in the global_dirty_tracking and it should require dirty ring too to be there, but I haven't thought deeper.. Then after that, we may teach migration code some algorithm to auto-setup these per-vcpu throttling, it'll grow into some kind of per-vcpu auto-converge. Do you think above would be something worth trying out? And.. Dave/Paolo/Juan? Btw, this series cannot apply cleanly to master here. Maybe you need to pull and rebase? -- Peter Xu