From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
robh+dt@kernel.org, asutoshd@codeaurora.org,
stummala@codeaurora.org, vbadigan@codeaurora.org,
rampraka@codeaurora.org, sayalil@codeaurora.org,
sartgarg@codeaurora.org, rnayak@codeaurora.org,
saiprakash.ranjan@codeaurora.org, sibis@codeaurora.org,
okukatla@codeaurora.org, djakov@kernel.org, cang@codeaurora.org,
pragalla@codeaurora.org, nitirawa@codeaurora.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
agross@kernel.org
Subject: Re: [PATCH V2] arm64: dts: qcom: sc7180: Add xo clock for eMMC and Sd card
Date: Fri, 18 Jun 2021 12:44:47 -0500 [thread overview]
Message-ID: <YMzbj9uaAPcpwIhF@builder.lan> (raw)
In-Reply-To: <1623835059-29302-1-git-send-email-sbhanu@codeaurora.org>
On Wed 16 Jun 04:17 CDT 2021, Shaik Sajida Bhanu wrote:
> Add XO clock for eMMC and SDCard as it would help in calculating dll
> register values.
>
> Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>
> Changes since V1:
> - Updated commit message as suggested by Bjorn Andersson.
> - Added space after before xo clock name as suggested by
> Konrad Dybcio.
Thank you Shaik. Sorry if I wasn't clear when I tried to say that I
fixed these things and applied your previous patch.
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 52115e0..fb1d9ad 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -701,8 +701,9 @@
> interrupt-names = "hc_irq", "pwr_irq";
>
> clocks = <&gcc GCC_SDCC1_APPS_CLK>,
> - <&gcc GCC_SDCC1_AHB_CLK>;
> - clock-names = "core", "iface";
> + <&gcc GCC_SDCC1_AHB_CLK>,
> + <&rpmhcc RPMH_CXO_CLK>;
> + clock-names = "core", "iface", "xo";
> interconnects = <&aggre1_noc MASTER_EMMC 0 &mc_virt SLAVE_EBI1 0>,
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_EMMC_CFG 0>;
> interconnect-names = "sdhc-ddr","cpu-sdhc";
> @@ -2564,8 +2565,9 @@
> interrupt-names = "hc_irq", "pwr_irq";
>
> clocks = <&gcc GCC_SDCC2_APPS_CLK>,
> - <&gcc GCC_SDCC2_AHB_CLK>;
> - clock-names = "core", "iface";
> + <&gcc GCC_SDCC2_AHB_CLK>,
> + <&rpmhcc RPMH_CXO_CLK>;
> + clock-names = "core", "iface", "xo";
>
> interconnects = <&aggre1_noc MASTER_SDCC_2 0 &mc_virt SLAVE_EBI1 0>,
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_SDCC_2 0>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
prev parent reply other threads:[~2021-06-18 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:17 [PATCH V2] arm64: dts: qcom: sc7180: Add xo clock for eMMC and Sd card Shaik Sajida Bhanu
2021-06-16 12:46 ` Konrad Dybcio
2021-06-18 17:44 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMzbj9uaAPcpwIhF@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nitirawa@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=pragalla@codeaurora.org \
--cc=rampraka@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sartgarg@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=sbhanu@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.