From: Leah Rumancik <leah.rumancik@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT
Date: Fri, 2 Jul 2021 15:45:46 -0700 [thread overview]
Message-ID: <YN+XGsHSnu+SerWU@google.com> (raw)
In-Reply-To: <20210702173425.1276158-1-tytso@mit.edu>
On Fri, Jul 02, 2021 at 01:34:25PM -0400, Theodore Ts'o wrote:
> Use the correct bitmask when checking for any not-yet-supported flags.
>
> Fixes: 351a0a3fbc35 ("ext4: add ioctl EXT4_IOC_CHECKPOINT")
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: Leah Rumancik <leah.rumancik@gmail.com>
> ---
> fs/ext4/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 5730aeca563c..6eed6170aded 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -823,7 +823,7 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
> if (!EXT4_SB(sb)->s_journal)
> return -ENODEV;
>
> - if (flags & ~JBD2_JOURNAL_FLUSH_VALID)
> + if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
> return -EINVAL;
>
> q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
> --
> 2.31.0
>
Thanks for the fix.
Reviewed-by: Leah Rumancik <leah.rumancik@gmail.com>
-Leah
prev parent reply other threads:[~2021-07-02 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 17:34 [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT Theodore Ts'o
2021-07-02 22:45 ` Leah Rumancik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN+XGsHSnu+SerWU@google.com \
--to=leah.rumancik@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.