From: "Theodore Ts'o" <tytso@mit.edu>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH 1/2] fs: ext4: Consolidate checks for resize of bigalloc into ext4_resize_begin
Date: Wed, 30 Jun 2021 20:48:04 -0400 [thread overview]
Message-ID: <YN0QxMh7ymC8obre@mit.edu> (raw)
In-Reply-To: <YNSVUy/DTWdhzuci@mit.edu>
On Thu, Jun 24, 2021 at 10:23:15AM -0400, Theodore Ts'o wrote:
> On Mon, Jun 07, 2021 at 12:15:08PM -0700, Josh Triplett wrote:
> > Two different places checked for attempts to resize a filesystem with
> > the bigalloc feature. Move the check into ext4_resize_begin, which both
> > places already call.
> >
> > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
>
> Applied, thanks.
I'm going to have to revert this change, since it breaks online
resizing for bigalloc file system. The issue is that
ext4_resize_begin() is called from *three* places: for
EXT4_IOC_GROUP_ADD, EXT4_IOC_GROUP_EXTEND, and EXT4_IOC_RESIZE_FS.
The first two ioctls are used for the "old-style" online resize, and
bigalloc is not supported for those two ioctls. However, it *is*
supposed to work for EXT4_IOC_RESIZE_FS.
Unfortunately, this just caused some tests to be skipped (assuming
that this was an old kernel that didn't support this feature) and I
didn't notice it right away.
- Ted
next prev parent reply other threads:[~2021-07-01 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 19:15 [PATCH 1/2] fs: ext4: Consolidate checks for resize of bigalloc into ext4_resize_begin Josh Triplett
2021-06-07 19:15 ` [PATCH 2/2] fs: ext4: Add check to prevent attempting to resize an fs with sparse_super2 Josh Triplett
2021-06-24 14:23 ` Theodore Ts'o
2021-06-24 14:23 ` [PATCH 1/2] fs: ext4: Consolidate checks for resize of bigalloc into ext4_resize_begin Theodore Ts'o
2021-07-01 0:48 ` Theodore Ts'o [this message]
2021-07-01 2:17 ` Josh Triplett
2021-07-01 14:41 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN0QxMh7ymC8obre@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=josh@joshtriplett.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.