From: Christoph Hellwig <hch@infradead.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: bvanassche@acm.org, jejb@linux.ibm.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
kernel@puri.sm, stern@rowland.harvard.edu
Subject: Re: [PATCH v5 2/3] scsi: sd: send REQUEST SENSE for BLIST_MEDIA_CHANGE devices in runtime_resume()
Date: Thu, 1 Jul 2021 15:49:51 +0100 [thread overview]
Message-ID: <YN3WD4Vem5Zx8Dvq@infradead.org> (raw)
In-Reply-To: <20210630084453.186764-3-martin.kepplinger@puri.sm>
On Wed, Jun 30, 2021 at 10:44:52AM +0200, Martin Kepplinger wrote:
> + struct scsi_disk *sdkp = dev_get_drvdata(dev);
> + struct scsi_device *sdp = sdkp->device;
> + int timeout, res;
> +
> + timeout = sdp->request_queue->rq_timeout * SD_FLUSH_TIMEOUT_MULTIPLIER;
Is REQUEST SENSE reqlly a so slow operation on these devices that
we need to override the timeout?
next prev parent reply other threads:[~2021-07-01 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 8:44 [PATCH v5 0/3] fix runtime PM for SD card readers Martin Kepplinger
2021-06-30 8:44 ` [PATCH v5 1/3] scsi: devinfo: add new flag BLIST_MEDIA_CHANGE Martin Kepplinger
2021-06-30 8:44 ` [PATCH v5 2/3] scsi: sd: send REQUEST SENSE for BLIST_MEDIA_CHANGE devices in runtime_resume() Martin Kepplinger
2021-07-01 14:35 ` Bart Van Assche
2021-07-01 14:49 ` Christoph Hellwig [this message]
2021-07-02 8:04 ` Martin Kepplinger
2021-07-02 13:43 ` Bart Van Assche
2021-06-30 8:44 ` [PATCH v5 3/3] scsi: devinfo: add BLIST_MEDIA_CHANGE for Ultra HS-SD/MMC usb cardreaders Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN3WD4Vem5Zx8Dvq@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.