From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: masami.hiramatsu@linaro.org, takahiro.akashi@linaro.org,
Michal Simek <michal.simek@xilinx.com>,
Alexander Graf <agraf@csgraf.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH 2/3 v3] efi_loader: Force a sinlge FMP instance per hardware store
Date: Fri, 2 Jul 2021 10:32:42 +0300 [thread overview]
Message-ID: <YN7BGgtHMikR1Isu@enceladus> (raw)
In-Reply-To: <fad4cc8e-708a-71c6-8b08-585b14b07d48@gmx.de>
> > + bool "FMP driver for FIT images"
[...]
> > + depends on FIT
> > + depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
>
> Should here be:
>
> depends on SANDBOX || (!SANDBOX && !EFI_CAPSULE_FIRMWARE_RAW)
>
Well on of them is enough and makes them mutually exclusive. If you choose
EFI_CAPSULE_FIRMWARE_RAW in this specific case the FIT variant will dissapear.
I dont mind adding it for completeness, up to you
Cheers
/Ilias
> Best regards
>
> Heinrich
>
> > + select UPDATE_FIT
> > + select DFU
> > + select EFI_CAPSULE_FIRMWARE
> > + help
> > + Select this option if you want to enable firmware management protocol
> > + driver for FIT image
> > +
> > +config EFI_CAPSULE_FIRMWARE_RAW
> > + bool "FMP driver for raw images"
> > + depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
> > + depends on SANDBOX || (!SANDBOX && !EFI_CAPSULE_FIRMWARE_FIT)
> > + select DFU_WRITE_ALT
> > + select DFU
> > + select EFI_CAPSULE_FIRMWARE
> > + help
> > + Select this option if you want to enable firmware management protocol
> > + driver for raw image
> > +
> > config EFI_CAPSULE_AUTHENTICATE
> > bool "Update Capsule authentication"
> > depends on EFI_CAPSULE_FIRMWARE
> > @@ -181,29 +203,6 @@ config EFI_CAPSULE_AUTHENTICATE
> > Select this option if you want to enable capsule
> > authentication
> >
> > -config EFI_CAPSULE_FIRMWARE_FIT
> > - bool "FMP driver for FIT image"
> > - depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
> > - depends on FIT
> > - select UPDATE_FIT
> > - select DFU
> > - select EFI_CAPSULE_FIRMWARE
> > - default n
> > - help
> > - Select this option if you want to enable firmware management protocol
> > - driver for FIT image
> > -
> > -config EFI_CAPSULE_FIRMWARE_RAW
> > - bool "FMP driver for raw image"
> > - depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
> > - select DFU
> > - select DFU_WRITE_ALT
> > - select EFI_CAPSULE_FIRMWARE
> > - default n
> > - help
> > - Select this option if you want to enable firmware management protocol
> > - driver for raw image
> > -
> > config EFI_DEVICE_PATH_TO_TEXT
> > bool "Device path to text protocol"
> > default y
> >
>
next prev parent reply other threads:[~2021-07-02 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:38 [PATCH 1/3 v3] efi: Fix to use null handle to create new handle for efi_fmp_raw Ilias Apalodimas
2021-06-22 14:38 ` [PATCH 2/3 v3] efi_loader: Force a sinlge FMP instance per hardware store Ilias Apalodimas
2021-06-22 23:57 ` Masami Hiramatsu
2021-07-02 7:25 ` Heinrich Schuchardt
2021-07-02 7:32 ` Ilias Apalodimas [this message]
2021-06-22 14:38 ` [PATCH 3/3 v3] efi_loader: Always install FMPs Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN7BGgtHMikR1Isu@enceladus \
--to=ilias.apalodimas@linaro.org \
--cc=agraf@csgraf.de \
--cc=masami.hiramatsu@linaro.org \
--cc=michal.simek@xilinx.com \
--cc=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.