From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Barry Song <song.bao.hua@hisilicon.com>
Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, dave.hansen@intel.com,
yury.norov@gmail.com, linux@rasmusvillemoes.dk,
rafael@kernel.org, rdunlap@infradead.org, agordeev@linux.ibm.com,
sbrivio@redhat.com, jianpeng.ma@intel.com,
valentin.schneider@arm.com, peterz@infradead.org,
bristot@redhat.com, guodong.xu@linaro.org,
tangchengchang@huawei.com, prime.zeng@hisilicon.com,
yangyicong@huawei.com, tim.c.chen@linux.intel.com,
linuxarm@huawei.com, Tian Tao <tiantao6@hisilicon.com>
Subject: Re: [PATCH v5 3/3] drivers/base/node.c: use bin_attribute to break the size limitation of cpumap ABI
Date: Fri, 2 Jul 2021 13:03:36 +0300 [thread overview]
Message-ID: <YN7keAGnfQrM1RBF@smile.fi.intel.com> (raw)
In-Reply-To: <20210702092559.8776-4-song.bao.hua@hisilicon.com>
On Fri, Jul 02, 2021 at 09:25:59PM +1200, Barry Song wrote:
> From: Tian Tao <tiantao6@hisilicon.com>
>
> Reading sys/devices/system/cpu/cpuX/nodeX/ returns cpumap and cpulist.
> However, the size of this file is limited to PAGE_SIZE because of the
> limitation for sysfs attribute.
>
> This patch moves to use bin_attribute to extend the ABI to be more
> than one page so that cpumap bitmask and list won't be potentially
> trimmed.
...
> }
>
> -static DEVICE_ATTR_RO(cpumap);
>
> -static inline ssize_t cpulist_show(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> +static BIN_ATTR_RO(cpumap, 0);
It will be extra blank line after this change.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-07-02 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 9:25 [PATCH v5 0/3] use bin_attribute to break the size limitation of cpumap ABI Barry Song
2021-07-02 9:25 ` [PATCH v5 1/3] cpumask: introduce cpumap_print_to_buf to support large bitmask and list Barry Song
2021-07-02 10:07 ` Andy Shevchenko
2021-07-02 21:30 ` Yury Norov
2021-07-03 8:23 ` Song Bao Hua (Barry Song)
2021-07-02 9:25 ` [PATCH v5 2/3] topology: use bin_attribute to break the size limitation of cpumap ABI Barry Song
2021-07-02 12:54 ` kernel test robot
2021-07-02 12:54 ` kernel test robot
2021-07-02 16:33 ` kernel test robot
2021-07-02 16:33 ` kernel test robot
2021-07-02 9:25 ` [PATCH v5 3/3] drivers/base/node.c: " Barry Song
2021-07-02 10:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN7keAGnfQrM1RBF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=jianpeng.ma@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxarm@huawei.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sbrivio@redhat.com \
--cc=song.bao.hua@hisilicon.com \
--cc=tangchengchang@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=tim.c.chen@linux.intel.com \
--cc=valentin.schneider@arm.com \
--cc=yangyicong@huawei.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.