From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3482C11F6A for ; Fri, 2 Jul 2021 10:28:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95FA76140E for ; Fri, 2 Jul 2021 10:28:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95FA76140E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 26E9189854; Fri, 2 Jul 2021 10:28:59 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C60B897F3 for ; Fri, 2 Jul 2021 10:28:56 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 4a1e50b6-db20-11eb-9082-0050568c148b; Fri, 02 Jul 2021 10:28:49 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 8E88F194B1A; Fri, 2 Jul 2021 12:28:59 +0200 (CEST) Date: Fri, 2 Jul 2021 12:28:53 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Linus Walleij Subject: Re: [PATCH v2] drm/dbi: Print errors for mipi_dbi_command() Message-ID: References: <20210702100455.3928920-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , Douglas Anderson , dri-devel@lists.freedesktop.org, Noralf =?iso-8859-1?Q?Tr=F8nnes?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 02, 2021 at 12:27:42PM +0200, Sam Ravnborg wrote: > On Fri, Jul 02, 2021 at 12:04:55PM +0200, Linus Walleij wrote: > > The macro mipi_dbi_command() does not report errors unless you wrap it > > in another macro to do the error reporting. > > > > Report a rate-limited error so we know what is going on. > > > > Drop the only user in DRM using mipi_dbi_command() and actually checking > > the error explicitly, let it use mipi_dbi_command_buf() directly > > instead. > > > > After this any code wishing to send command arrays can rely on > > mipi_dbi_command() providing an appropriate error message if something > > goes wrong. > > > > Suggested-by: Noralf Trønnes > > Suggested-by: Douglas Anderson > > Signed-off-by: Linus Walleij > Signed-off-by: Sam Ravnborg Too fast send, this should read: Reviewed-by: Sam Ravnborg