From: Andrew Lunn <andrew@lunn.ch>
To: Qing Zhang <zhangqing@loongson.cn>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Rob Herring <robh+dt@kernel.org>, Huacai Chen <chenhc@lemote.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] MIPS: Loongson64: Add GMAC support for Loongson-2K1000
Date: Mon, 21 Jun 2021 04:59:47 +0200 [thread overview]
Message-ID: <YNAAo+ABaMVmArcM@lunn.ch> (raw)
In-Reply-To: <20210618025337.5705-2-zhangqing@loongson.cn>
> + gmac@3,1 {
> + compatible = "pci0014,7a03.0",
> + "pci0014,7a03",
> + "pciclass0c0320",
> + "pciclass0c03",
> + "loongson, pci-gmac";
> +
> + reg = <0x1900 0x0 0x0 0x0 0x0>;
> + interrupts = <14 IRQ_TYPE_LEVEL_LOW>,
> + <15 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "macirq", "eth_lpi";
> + interrupt-parent = <&liointc0>;
> + phy-mode = "rgmii";
rgmii? But you set PHY_INTERFACE_MODE_GMII?
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + phy1: ethernet-phy@1 {
> + reg = <0>;
The value after the @ should match the reg value.
Andrew
next prev parent reply other threads:[~2021-06-21 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 2:53 [PATCH 1/4] stmmac: pci: Add dwmac support for Loongson Qing Zhang
2021-06-18 2:53 ` [PATCH 2/4] MIPS: Loongson64: Add GMAC support for Loongson-2K1000 Qing Zhang
2021-06-21 2:59 ` Andrew Lunn [this message]
2021-06-18 2:53 ` [PATCH 3/4] MIPS: Loongson64: DTS: Add GMAC support for LS7A PCH Qing Zhang
2021-06-18 2:53 ` [PATCH 4/4] dt-bindings: dwmac: Add bindings for new Loongson SoC and bridge chip Qing Zhang
2021-06-21 2:55 ` [PATCH 1/4] stmmac: pci: Add dwmac support for Loongson Andrew Lunn
2021-06-22 2:10 ` zhangqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNAAo+ABaMVmArcM@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=chenhc@lemote.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.