From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD932C4743C for ; Mon, 21 Jun 2021 12:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4E056101D for ; Mon, 21 Jun 2021 12:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230047AbhFUMvG (ORCPT ); Mon, 21 Jun 2021 08:51:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47500 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbhFUMvF (ORCPT ); Mon, 21 Jun 2021 08:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=rUyQk3yoW9NXwQ+YnSBUagkXImneZQ9YSpSYesCXmdk=; b=eldbcd/U6YqbWILz9FfaWBFOMA sKcBYoPl8Lz5NeliMY4elp7vFhKxKy8QFK9Dxs/4OSxPR4m0WtxJCsjTxgjaz1WFv/cW9HHgLh6k9 c0XFcgv8W4LbXr9gUm8fg++McspSaEtPoXZJ/JMVyr6mL6yrtKQDJcp18XGEhmpLtRO0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lvJM8-00AVFN-AL; Mon, 21 Jun 2021 14:48:48 +0200 Date: Mon, 21 Jun 2021 14:48:48 +0200 From: Andrew Lunn To: Liang Xu Cc: Florian Fainelli , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "kuba@kernel.org" , "vee.khee.wong@linux.intel.com" , "linux@armlinux.org.uk" , Hauke Mehrtens , Thomas Mohren Subject: Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver Message-ID: References: <7834258b-5826-1c00-2754-b0b7e76b5910@maxlinear.com> <2b9945f9-16a4-bda5-40df-d79089be3c12@maxlinear.com> <9a838afe-83e7-b575-db49-f210022966d5@maxlinear.com> <334b52a6-30e8-0869-6ffb-52e9955235ff@maxlinear.com> <2f6c23fd-724e-c9e0-83f2-791cb747d846@maxlinear.com> <298d6268-00d0-cfcf-3689-bd074cbd8e16@maxlinear.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <298d6268-00d0-cfcf-3689-bd074cbd8e16@maxlinear.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 21, 2021 at 05:05:06AM +0000, Liang Xu wrote: > On 21/6/2021 10:30 am, Andrew Lunn wrote: > > This email was sent from outside of MaxLinear. > > > > > > On Fri, Jun 18, 2021 at 03:36:35PM +0000, Liang Xu wrote: > >> On 18/6/2021 10:01 pm, Andrew Lunn wrote: > >>> This email was sent from outside of MaxLinear. > >>> > >>> > >>>> Net-next: > >>>> > >>>> int genphy_loopback(struct phy_device *phydev, bool enable) > >>>> { > >>>> if (enable) { > >>>> u16 val, ctl = BMCR_LOOPBACK; > >>>> int ret; > >>>> > >>>> if (phydev->speed == SPEED_1000) > >>>> ctl |= BMCR_SPEED1000; > >>>> else if (phydev->speed == SPEED_100) > >>>> ctl |= BMCR_SPEED100; > >> The problem happens in the speed change no matter it's forced or > >> auto-neg in our device. > > You say speed change. So do you just need to add support for 10Mbps, > > so there is no speed change? Or are you saying phydev->speed does not > > match the actual speed? > > > > Andrew > > > We have 2.5G link speed, so mismatch happens. Ah, yes. Sorry. Please implement it in your driver. Andrew