From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 811EEC4743C for ; Mon, 21 Jun 2021 13:07:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 503D761156 for ; Mon, 21 Jun 2021 13:07:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 503D761156 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Drr0wYVSU1Y/YftVhz2Dq5jVbYXNPzMS6Es0xYnNDYk=; b=w3ASPM+amvytJR iYnoauFBOg8LxPzfY43ZoLXDk9RfIGUY4k3Oa2aNYUFcFVxnh11IASZ3WvyUB7+p9/AwaoqU0dBvW LjTy3AKHOHcipV/BmRU8xu3Inwm9EwRxeLheAmx4s4tz2N4hKqZAy1+PCt8qnIcRemcp15CVhURbo 7BdQIIpKCK5D3juXarLTedJVbv7ApCpjL97UkDPygz02SuiRoMJiCmqWYpzE4gj+ME8g3in9+uM1z cEXmwQn6aXRyOee6JGeech6naeUhxx70PO1Ufd1BOZp6sM2+g99DWNCSXcYMam2sbkh6BAG4Gl3dO 5sVQorBP87vbBcZVINfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvJct-003XuP-GO; Mon, 21 Jun 2021 13:06:07 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvJco-003Xt4-It for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 13:06:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vZwauemkwVd28l2j/FRyIlgC3dtVqFc07kW48PeHXL4=; b=P6wtPnCfNEgooXieezZE104G9J psG16da7CyrdETa3ia7vlhCuS1FZgcwN+e0VfNEyDlAVuSvqTVu0s0WuOvU4pV1kMNJUoAjs9GdvM s5s7nbrntL712rS0c3CtYxJ3P6vXCSroHmrEGQPXd225oPa1FfWsdmzudeZrBALFcFgU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lvJcW-00AVLt-0Y; Mon, 21 Jun 2021 15:05:44 +0200 Date: Mon, 21 Jun 2021 15:05:44 +0200 From: Andrew Lunn To: Ling Pei Lee Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Russell King , Ong Boon Leong , Voon Weifeng , Wong Vee Khee , Wong Vee Khee , Tan Tee Min , Michael Sit Wei Hong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL settings in stmmac_resume() Message-ID: References: <20210621094536.387442-1-pei.lee.ling@intel.com> <20210621094536.387442-4-pei.lee.ling@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210621094536.387442-4-pei.lee.ling@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_060602_666335_2F0EF28E X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 21, 2021 at 05:45:35PM +0800, Ling Pei Lee wrote: > From: Muhammad Husaini Zulkifli > > After PHY received a magic packet, the PHY WOL event will be > triggered then PHY WOL event interrupt will be disarmed. > Ethtool settings will remain with WOL enabled after a S3/S4 > suspend resume cycle as expected. Hence,the driver should > reconfigure the PHY settings to reenable/disable WOL > depending on the ethtool WOL settings in the resume flow. Please could you explain this a bit more? I'm wondering if you have a PHY driver bug. PHY WOL should remain enabled until it is explicitly disabled. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E66C49EA2 for ; Mon, 21 Jun 2021 13:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B05C61156 for ; Mon, 21 Jun 2021 13:06:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbhFUNIP (ORCPT ); Mon, 21 Jun 2021 09:08:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47548 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbhFUNIO (ORCPT ); Mon, 21 Jun 2021 09:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vZwauemkwVd28l2j/FRyIlgC3dtVqFc07kW48PeHXL4=; b=P6wtPnCfNEgooXieezZE104G9J psG16da7CyrdETa3ia7vlhCuS1FZgcwN+e0VfNEyDlAVuSvqTVu0s0WuOvU4pV1kMNJUoAjs9GdvM s5s7nbrntL712rS0c3CtYxJ3P6vXCSroHmrEGQPXd225oPa1FfWsdmzudeZrBALFcFgU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lvJcW-00AVLt-0Y; Mon, 21 Jun 2021 15:05:44 +0200 Date: Mon, 21 Jun 2021 15:05:44 +0200 From: Andrew Lunn To: Ling Pei Lee Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Russell King , Ong Boon Leong , Voon Weifeng , Wong Vee Khee , Wong Vee Khee , Tan Tee Min , Michael Sit Wei Hong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL settings in stmmac_resume() Message-ID: References: <20210621094536.387442-1-pei.lee.ling@intel.com> <20210621094536.387442-4-pei.lee.ling@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621094536.387442-4-pei.lee.ling@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 05:45:35PM +0800, Ling Pei Lee wrote: > From: Muhammad Husaini Zulkifli > > After PHY received a magic packet, the PHY WOL event will be > triggered then PHY WOL event interrupt will be disarmed. > Ethtool settings will remain with WOL enabled after a S3/S4 > suspend resume cycle as expected. Hence,the driver should > reconfigure the PHY settings to reenable/disable WOL > depending on the ethtool WOL settings in the resume flow. Please could you explain this a bit more? I'm wondering if you have a PHY driver bug. PHY WOL should remain enabled until it is explicitly disabled. Andrew