From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F02C48BC2 for ; Mon, 21 Jun 2021 14:27:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9972861151 for ; Mon, 21 Jun 2021 14:27:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9972861151 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FEBE6E17F; Mon, 21 Jun 2021 14:27:50 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 397BE6E17F for ; Mon, 21 Jun 2021 14:27:49 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B6B75D6B; Mon, 21 Jun 2021 16:27:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624285667; bh=7L3oTmVXoz7x5fNyzOZRs2Vf9NqEwqMSuOKnDXVsMC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tyjk+gjuggWCdEMcb3SdTePBeyfnl9wB2zuMp1n6UwdfzD7Q0aPq+9XyTstU3ggkJ 15Zl1dq9LzahQwviLSPMXAnCWiYRRSUe7ddcUqJsqJ99YbdY7U5Z+JY+KK4R9JVvv6 6mX79t4+O1EN1slk1Xg1UeOy5nTkfHkQ9sxLLI/o= Date: Mon, 21 Jun 2021 17:27:21 +0300 From: Laurent Pinchart To: Stefan =?utf-8?Q?Riedm=C3=BCller?= Subject: Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel Message-ID: References: <20210415091616.53415-1-s.riedmueller@phytec.de> <57bf547d95ba84f72d0f9da0e687fbe71311e5b8.camel@phytec.de> <5942e9c67f7d50737536613b80a2cb42a3615b3d.camel@phytec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5942e9c67f7d50737536613b80a2cb42a3615b3d.camel@phytec.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "thierry.reding@gmail.com" , "sam@ravnborg.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Stefan, Thank you for the patch. On Mon, Jun 21, 2021 at 08:22:10AM +0000, Stefan Riedmüller wrote: > Hi, > > another gentle ping. Sorry for the delay, I have way too little bandwidth these days :-S > Also adding Laurent Pinchart to CC. > > On Wed, 2021-05-26 at 07:34 +0000, Stefan Riedmüller wrote: > > On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote: > > > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. > > > Add the corresponding connector type and 8 bpc as default bus_format. > > > > > > Signed-off-by: Stefan Riedmueller Reviewed-by: Laurent Pinchart It will be interesting to add support for the 6bpp mode at some point (I assume through a custom DT property that reports the state of the panel's SEL68 pin, as it should be strapped in most cases). > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > > b/drivers/gpu/drm/panel/panel-simple.c > > > index 4e2dad314c79..44583d0ed902 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = { > > > .width = 211, > > > .height = 158, > > > }, > > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > > }; > > > > > > static const struct drm_display_mode auo_g121ean01_mode = { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA154C4743C for ; Mon, 21 Jun 2021 14:27:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94A6B6115A for ; Mon, 21 Jun 2021 14:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230076AbhFUOaD (ORCPT ); Mon, 21 Jun 2021 10:30:03 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:55276 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbhFUOaC (ORCPT ); Mon, 21 Jun 2021 10:30:02 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B6B75D6B; Mon, 21 Jun 2021 16:27:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624285667; bh=7L3oTmVXoz7x5fNyzOZRs2Vf9NqEwqMSuOKnDXVsMC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tyjk+gjuggWCdEMcb3SdTePBeyfnl9wB2zuMp1n6UwdfzD7Q0aPq+9XyTstU3ggkJ 15Zl1dq9LzahQwviLSPMXAnCWiYRRSUe7ddcUqJsqJ99YbdY7U5Z+JY+KK4R9JVvv6 6mX79t4+O1EN1slk1Xg1UeOy5nTkfHkQ9sxLLI/o= Date: Mon, 21 Jun 2021 17:27:21 +0300 From: Laurent Pinchart To: Stefan =?utf-8?Q?Riedm=C3=BCller?= Cc: "daniel@ffwll.ch" , "airlied@linux.ie" , "sam@ravnborg.org" , "thierry.reding@gmail.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel Message-ID: References: <20210415091616.53415-1-s.riedmueller@phytec.de> <57bf547d95ba84f72d0f9da0e687fbe71311e5b8.camel@phytec.de> <5942e9c67f7d50737536613b80a2cb42a3615b3d.camel@phytec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5942e9c67f7d50737536613b80a2cb42a3615b3d.camel@phytec.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, Thank you for the patch. On Mon, Jun 21, 2021 at 08:22:10AM +0000, Stefan Riedmüller wrote: > Hi, > > another gentle ping. Sorry for the delay, I have way too little bandwidth these days :-S > Also adding Laurent Pinchart to CC. > > On Wed, 2021-05-26 at 07:34 +0000, Stefan Riedmüller wrote: > > On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote: > > > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. > > > Add the corresponding connector type and 8 bpc as default bus_format. > > > > > > Signed-off-by: Stefan Riedmueller Reviewed-by: Laurent Pinchart It will be interesting to add support for the 6bpp mode at some point (I assume through a custom DT property that reports the state of the panel's SEL68 pin, as it should be strapped in most cases). > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > > b/drivers/gpu/drm/panel/panel-simple.c > > > index 4e2dad314c79..44583d0ed902 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = { > > > .width = 211, > > > .height = 158, > > > }, > > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > > }; > > > > > > static const struct drm_display_mode auo_g121ean01_mode = { -- Regards, Laurent Pinchart