All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/556: add a check to make sure ext4 supports encrypted casefolding
Date: Mon, 21 Jun 2021 10:37:58 -0700	[thread overview]
Message-ID: <YNDOdrW0cEOhC9rZ@gmail.com> (raw)
In-Reply-To: <20210621164901.1809010-1-tytso@mit.edu>

On Mon, Jun 21, 2021 at 12:49:01PM -0400, Theodore Ts'o wrote:
> diff --git a/tests/generic/556 b/tests/generic/556
> index 3145188c..7916a08e 100755
> --- a/tests/generic/556
> +++ b/tests/generic/556
> @@ -16,6 +16,7 @@ status=1 # failure is thea default
>  . ./common/attr
>  
>  _supported_fs generic
> +_require_encrypted_casefold

This isn't an encrypt+casefold test though, but rather just a casefold test.  It
only becomes an encrypt+casefold test when $MOUNT_OPTIONS includes
test_dummy_encryption.

I think we shouldn't update the test itself, but rather make
_require_scratch_casefold() call _require_encrypted_casefold() if
test_dummy_encryption is in $MOUNT_OPTIONS.

- Eric

  parent reply	other threads:[~2021-06-21 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 16:49 [PATCH] generic/556: add a check to make sure ext4 supports encrypted casefolding Theodore Ts'o
2021-06-21 17:00 ` Darrick J. Wong
2021-06-21 17:37 ` Eric Biggers [this message]
2022-04-21 18:01   ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNDOdrW0cEOhC9rZ@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.