From: Greg KH <gregkh@linuxfoundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: rafael@kernel.org, jeyu@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, minchan@kernel.org,
axboe@kernel.dk, mbenes@suse.com, jpoimboe@redhat.com,
tglx@linutronix.de, keescook@chromium.org, jikos@kernel.org,
rostedt@goodmis.org, peterz@infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/base/core: refcount kobject and bus on device attribute read / store
Date: Tue, 22 Jun 2021 23:32:41 +0200 [thread overview]
Message-ID: <YNJW+ZnoV5w8PZhm@kroah.com> (raw)
In-Reply-To: <20210622210659.3708231-1-mcgrof@kernel.org>
On Tue, Jun 22, 2021 at 02:06:59PM -0700, Luis Chamberlain wrote:
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2039,31 +2039,68 @@ EXPORT_SYMBOL(dev_driver_string);
>
> #define to_dev_attr(_attr) container_of(_attr, struct device_attribute, attr)
>
> +struct bus_type *bus_get(struct bus_type *bus);
> +void bus_put(struct bus_type *bus);
> +
Didn't checkpatch complain about this?
We have a local .h file for stuff like this, can you please use it?
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-22 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 21:06 [PATCH] drivers/base/core: refcount kobject and bus on device attribute read / store Luis Chamberlain
2021-06-22 21:32 ` Greg KH [this message]
2021-06-22 21:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNJW+ZnoV5w8PZhm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.