From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] i2c: rcar: : use proper DMAENGINE API for termination
Date: Wed, 23 Jun 2021 16:08:08 +0200 [thread overview]
Message-ID: <YNNASBSYBu5lisae@ninjato> (raw)
In-Reply-To: <CAMuHMdVQ-XFy6fP_g70N8ukNPFj20ds-iEDF58Ocnpg7e5wLsQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
> Is this safe? The driver is not using a threaded irq, and DMA termination
> may be called from the interrupt handler.
You are right, this will not work. Not my best day today, I overlooked
it for i2c-rcar and lost the note pointing out the same issue for
stm32f7 :(
> Have you tried triggering DMA termination, with lockdep enabled?
Nope. As the code didn't show signs of async nature, I assumed sync was
desired anyhow.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-23 14:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 9:59 [PATCH 0/7] i2c: use proper DMAENGINE API for termination Wolfram Sang
2021-06-23 9:59 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 1/7] i2c: at91-master: : " Wolfram Sang
2021-06-23 9:59 ` Wolfram Sang
2021-07-13 9:07 ` Codrin.Ciubotariu
2021-07-13 9:07 ` Codrin.Ciubotariu
2021-08-11 13:24 ` Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-08-11 13:34 ` Codrin.Ciubotariu
2021-08-11 13:34 ` Codrin.Ciubotariu
2021-06-23 9:59 ` [PATCH 2/7] i2c: imx: " Wolfram Sang
2021-06-23 9:59 ` Wolfram Sang
2021-06-25 12:06 ` Oleksij Rempel
2021-06-25 12:06 ` Oleksij Rempel
2021-08-11 13:24 ` Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 3/7] i2c: mxs: " Wolfram Sang
2021-06-23 9:59 ` Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 4/7] i2c: qup: " Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 5/7] i2c: rcar: " Wolfram Sang
2021-06-23 14:02 ` Geert Uytterhoeven
2021-06-23 14:08 ` Wolfram Sang [this message]
2021-06-23 9:59 ` [PATCH 6/7] i2c: sh_mobile: " Wolfram Sang
2021-08-11 13:24 ` Wolfram Sang
2021-06-23 9:59 ` [PATCH 7/7] i2c: stm32f7: " Wolfram Sang
2021-06-23 9:59 ` Wolfram Sang
2021-06-23 14:03 ` Wolfram Sang
2021-06-23 14:03 ` Wolfram Sang
2021-06-30 13:11 ` Alain Volmat
2021-06-30 13:11 ` Alain Volmat
2021-06-30 13:48 ` Wolfram Sang
2021-06-30 13:48 ` Wolfram Sang
2021-08-11 13:26 ` [PATCH 0/7] i2c: " Wolfram Sang
2021-08-11 13:26 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNNASBSYBu5lisae@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.