From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6771CC48BDF for ; Thu, 24 Jun 2021 12:51:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3646861374 for ; Thu, 24 Jun 2021 12:51:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3646861374 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5012A6EB76; Thu, 24 Jun 2021 12:51:38 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 101CC6EB76 for ; Thu, 24 Jun 2021 12:51:37 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EA40501; Thu, 24 Jun 2021 14:51:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624539095; bh=FyM+hUpA+ywRvZffMmTR6lQUvy56qO0lVXxmkkg6Xew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ku9nJvuUoGHtfvBSCPhZUnzsdZa9u8aUgOKXavhhvXazoNEHeJUmF+XnBUufyEyDw 1VHzjJ+WKBohebiGedt87kbvxgGtmC9Ks0TSZ0H3ZF7iuIwMiv1vnU+XO21x8VHK+M SbVH2U84hYAwshMTNJ4e+pgpSJ5ks/Bcldv3ZRVk= Date: Thu, 24 Jun 2021 15:51:05 +0300 From: Laurent Pinchart To: Jonathan Liu Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe Message-ID: References: <20210203091306.140518-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Neil Armstrong , Sam Ravnborg , Jonas Karlman , Sandy Huang , dri-devel , Philippe Cornu , Yannick Fertre , Andrzej Hajda , Jagan Teki , Benjamin Gaignard , Vincent Abriou , linux-amarula , linux-kernel , Maxime Ripard Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" CC'ing Maxime Ripard. Maxime, is this similar to the issue we've recently discussed with the VC4 DSI encoder ? On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote: > On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote: > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote: > > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > > > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > > > > dw_mipi_dsi_debugfs_init(dsi); > > > > pm_runtime_enable(dev); > > > > > > > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, > > > > + &panel, &bridge); > > > > + if (ret) > > > > + return ERR_PTR(ret); > > > > > > On RK3399 if the error is EPROBE_DEFER, __dw_mipi_dsi_probe can be > > > called again and result in the following errors: > > > [ 0.717589] debugfs: Directory 'ff960000.mipi' with parent '/' already present! > > > [ 0.717601] dw-mipi-dsi-rockchip ff960000.mipi: failed to create debugfs root > > > [ 0.717606] dw-mipi-dsi-rockchip ff960000.mipi: Unbalanced pm_runtime_enable! > > > > Is this when you test bridge on rk3399 or panel? > > MIPI-DSI to LVDS bridge. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F15C49EA6 for ; Thu, 24 Jun 2021 12:51:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46BF6613F3 for ; Thu, 24 Jun 2021 12:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231720AbhFXMx6 (ORCPT ); Thu, 24 Jun 2021 08:53:58 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:41890 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbhFXMxz (ORCPT ); Thu, 24 Jun 2021 08:53:55 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EA40501; Thu, 24 Jun 2021 14:51:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624539095; bh=FyM+hUpA+ywRvZffMmTR6lQUvy56qO0lVXxmkkg6Xew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ku9nJvuUoGHtfvBSCPhZUnzsdZa9u8aUgOKXavhhvXazoNEHeJUmF+XnBUufyEyDw 1VHzjJ+WKBohebiGedt87kbvxgGtmC9Ks0TSZ0H3ZF7iuIwMiv1vnU+XO21x8VHK+M SbVH2U84hYAwshMTNJ4e+pgpSJ5ks/Bcldv3ZRVk= Date: Thu, 24 Jun 2021 15:51:05 +0300 From: Laurent Pinchart To: Jonathan Liu Cc: Jagan Teki , Andrzej Hajda , Neil Armstrong , Sandy Huang , Heiko Stubner , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Vincent Abriou , Jernej Skrabec , Jonas Karlman , Sam Ravnborg , linux-kernel , dri-devel , linux-amarula , Maxime Ripard Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe Message-ID: References: <20210203091306.140518-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC'ing Maxime Ripard. Maxime, is this similar to the issue we've recently discussed with the VC4 DSI encoder ? On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote: > On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote: > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote: > > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > > > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > > > > dw_mipi_dsi_debugfs_init(dsi); > > > > pm_runtime_enable(dev); > > > > > > > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, > > > > + &panel, &bridge); > > > > + if (ret) > > > > + return ERR_PTR(ret); > > > > > > On RK3399 if the error is EPROBE_DEFER, __dw_mipi_dsi_probe can be > > > called again and result in the following errors: > > > [ 0.717589] debugfs: Directory 'ff960000.mipi' with parent '/' already present! > > > [ 0.717601] dw-mipi-dsi-rockchip ff960000.mipi: failed to create debugfs root > > > [ 0.717606] dw-mipi-dsi-rockchip ff960000.mipi: Unbalanced pm_runtime_enable! > > > > Is this when you test bridge on rk3399 or panel? > > MIPI-DSI to LVDS bridge. -- Regards, Laurent Pinchart